Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Config to Pass Around Injected Args #146

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ranchodeluxe
Copy link
Collaborator

@ranchodeluxe ranchodeluxe added test-dataflow Add this label to PRs to trigger Dataflow integration test. test-flink Add this label to PRs to trigger Dataflow integration test. labels Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90479ab) 96.31% compared to head (a5ca82c) 96.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          15       15           
  Lines         489      489           
=======================================
  Hits          471      471           
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisaacstern
Copy link
Member

IIUC, this should not be necessary, providing pangeo-forge/pangeo-forge-recipes#652 correctly defines injection specs for Config (which it does). The explicit specs here are for backwards-compatibility for pangeo-forge-recipes releases which predate the injection system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-dataflow Add this label to PRs to trigger Dataflow integration test. test-flink Add this label to PRs to trigger Dataflow integration test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants