Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backend check to validate #368

Closed
wants to merge 8 commits into from
Closed

Add backend check to validate #368

wants to merge 8 commits into from

Conversation

grantjoy
Copy link
Contributor

@grantjoy grantjoy commented Sep 27, 2023 •
edited
Loading

Background

Validate only works over API key. This helps users understand that the validate mechanism doesn't work in the way they are attempting to use it.

Changes

  • Adds a better error message when validate is called without an API key being set

Testing

  • manually tested pat validate

@grantjoy grantjoy requested a review from a team September 27, 2023 23:47
@CLAassistant
Copy link

CLAassistant commented Sep 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

nskobov
nskobov previously approved these changes Sep 28, 2023
View reviewed changes
@grantjoy grantjoy closed this Oct 16, 2023
@grantjoy
Copy link
Contributor Author

closing in favor of #380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stedrow stedrow stedrow left review comments

@darwayne darwayne darwayne left review comments

@nskobov nskobov nskobov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@grantjoy @CLAassistant @darwayne @nskobov @stedrow @panther-bot-automation