Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating pip libraries and fixing linting errors the updates introduced #373

Closed
wants to merge 27 commits into from

Conversation

stedrow
Copy link
Contributor

@stedrow stedrow commented Oct 3, 2023

Background

Updated all pip libraries and cleaned up pipfile to remove unneeded libraries

Changes

  • Switched from nose to nose2
  • Updated tests to work with nose2
  • Updated code where needed for new recommendations from pylint and mypi:
    • Use of f-strings in place of older {} .format style
    • Adding Optional typing in places where variables were defaulting to None
    • Adding utf8-encoding for open functions
    • Adding timeout params for requests functions
    • Replacing dict() with {} literals
    • Replacing list() with [] literals
    • Adding maxsplit param to string splits
    • Switched one-liner open...read() statements to with open statements for file cleanup (no .close() needed), error handling and overall code readability

Testing

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2023

CLA assistant check
All committers have signed the CLA.

@stedrow stedrow changed the title Updateing pip requirements Updating pip libraries and fixing linting errors the updates introduced Oct 4, 2023
@stedrow stedrow deleted the branch master October 26, 2023 15:47
@stedrow stedrow closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants