-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pagination to Delete Commands #543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
le4ker
force-pushed
the
ben/delete-pagination
branch
from
September 19, 2024 14:57
e233c65
to
cce690a
Compare
le4ker
reviewed
Sep 19, 2024
le4ker
reviewed
Sep 19, 2024
le4ker
reviewed
Sep 19, 2024
le4ker
previously approved these changes
Sep 19, 2024
…bs/panther_analysis_tool into ben/delete-pagination
darwayne
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
delete
command cannot handle more than 100 IDs being passed at any given time, so this PR adds some basic pagination to that command. This is necessary because we intend to start deprecating rules and ask customers to run delete against a masterlist of IDs which will grow over time.Changes
PublicAPIClient.delete_saved_queries
andPublicAPIClient.delete_detections
to invoke the GQL endpoint in batches of 100 or lessTesting
pat delete
with 150 detection IDs and 150 query names_batched
function