Skip to content

Commit

Permalink
Reworked explanation for package aliases. Also removed note about spl…
Browse files Browse the repository at this point in the history
…itting into its own repo as this problem will not be solved as long as the package used is local
  • Loading branch information
tjcouch-sil committed Jan 22, 2024
1 parent 8600cd9 commit 600ea22
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions webpack/webpack.config.base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,12 @@ const configBase: webpack.Configuration = {
// use tsconfig.json paths https://www.npmjs.com/package/tsconfig-paths-webpack-plugin
new TsconfigPathsPlugin(),
],
// Load `papi-components`' `dependencies` from `paranext-core` so the extension will share these
// dependencies with the bundled copy of `papi-components` and avoid duplicate packages.
// These paths are broken up like this so multi-extension folder can format the path properly
// Load `platform-bible-react`' `dependencies` from `paranext-core` so the extension will share
// these dependencies with the bundled copy of `platform-bible-react` and avoid duplicate
// packages. These paths are broken up like this so multi-extension folder can format the path
// properly
// https://webpack.js.org/configuration/resolve/#resolvealias
// TODO: Remove this when `papi-components` is split into its own repo or is published to npm
// TODO: Remove this when `platform-bible-react` is published to npm
alias: {
'@emotion/react': path.resolve(
__dirname,
Expand Down

0 comments on commit 600ea22

Please sign in to comment.