-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed emotion package duplication #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tjcouch-sil)
webpack/webpack.config.base.ts
line 142 at r1 (raw file):
new TsconfigPathsPlugin(), ], // Load `papi-components`' `dependencies` from `paranext-core` so the extension will share these
Here I presume you mean platform-bible-react
? Change it 3 times.
Code quote:
papi-components
…itting into its own repo as this problem will not be solved as long as the package used is local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @irahopkinson)
webpack/webpack.config.base.ts
line 142 at r1 (raw file):
Previously, irahopkinson (Ira Hopkinson) wrote…
Here I presume you mean
platform-bible-react
? Change it 3 times.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 2 of 3 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is