Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed emotion package duplication #58

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

tjcouch-sil
Copy link
Member

@tjcouch-sil tjcouch-sil commented Jan 19, 2024

This change is Reviewable

@tjcouch-sil tjcouch-sil enabled auto-merge January 19, 2024 15:29
Copy link
Contributor

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tjcouch-sil)


webpack/webpack.config.base.ts line 142 at r1 (raw file):

      new TsconfigPathsPlugin(),
    ],
    // Load `papi-components`' `dependencies` from `paranext-core` so the extension will share these

Here I presume you mean platform-bible-react? Change it 3 times.

Code quote:

papi-components

…itting into its own repo as this problem will not be solved as long as the package used is local
Copy link
Member Author

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @irahopkinson)


webpack/webpack.config.base.ts line 142 at r1 (raw file):

Previously, irahopkinson (Ira Hopkinson) wrote…

Here I presume you mean platform-bible-react? Change it 3 times.

Done.

Copy link
Contributor

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks

Reviewed all commit messages.
Reviewable status: 2 of 3 files reviewed, all discussions resolved

Copy link
Contributor

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@tjcouch-sil tjcouch-sil merged commit 5680aa4 into main Jan 22, 2024
3 checks passed
@tjcouch-sil tjcouch-sil deleted the 594-emotional-therapy branch January 22, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants