Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Shared Scripture Editor, bump version to 0.0.2 #11

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

tjcouch-sil
Copy link
Member

@tjcouch-sil tjcouch-sil commented Mar 6, 2024

Wow 🤩

image

Bumped version because we released core 0.2.2 with these bundled in right before this change.

And ugh tsx... I had a sinking feeling it wasn't going to work very well. Already found a problem (it threw an error in npm run zip). But fortunately for some reason ts-node worked so 🤷

Here's tsx's great error:

C:\Users\tj_co\source\repos\paratext-bible-extensions\node_modules\tsx\dist\index-971a6964.cjs:16
Did you specify these with the most recent transformation maps first?`);let s=kt(i,e,"",0);for(let a=A.length-1;a>=0;a--)s=Bt(A[a],[s]);return s}function kt(n,e,A,i){const{resolvedSources:s,sourcesContent:a}=n,c=i+1,g=s.map((u,C)=>{const h={importer:A,depth:c,source:u||"",content:void 0},r=e(h.source,h),{source:b,content:y}=h;if(r)return kt(new st(r,b),e,b,c);const w=y!==void 0?y:a?a[C]:null;return ir(b,w)});return Bt(n,g)}class ar{constructor(e,A){const i=A.decodedMappings?me(e):ht(e);this.version=i.version,this.file=i.file,this.mappings=i.mappings,this.names=i.names,this.sourceRoot=i.sourceRoot,this.sources=i.sources,A.excludeContent||(this.sourcesContent=i.sourcesContent)}toString(){return JSON.stringify(this)}}function wt(n,e,A){const i=typeof A=="object"?A:{excludeContent:!!A,decodedMappings:!1},s=or(n,e);return new ar(nr(s),i)}const cr=(n,e,A)=>{const i=[],s={code:e};for(const a of A){const c=a(n,s.code);c&&(Object.assign(s,c),i.unshift(c.map))}return{...s,map:wt(i,()=>null)}},Qr=async(n,e,A)=>{const i=[],s={code:e};for(const a of A){const c=await a(n,s.code);c&&(Object.assign(s,c),i.unshift(c.map))}return{...s,map:wt(i,()=>null)}},lr=Object.freeze({target:`node${process.versions.node}`,loader:"default"}),It={...lr,sourcemap:!0,sourcesContent:!1,minifyWhitespace:!0,keepNames:!0},pt=n=>{const e=n.sourcefile;if(e){const A=P.extname(e);A?(A===".cts"||A===".mts")&&(n.sourcefile=`${e.slice(0,-3)}ts`):n.sourcefile+=".js"}return A=>(A.map&&(n.sourcefile!==e&&(A.map=A.map.replace(JSON.stringify(n.sourcefile),JSON.stringify(e))),A.map=JSON.parse(A.map)),A)},bt=n=>{const[e]=n.errors;let A=`[esbuild Error]: ${e.text}`;if(e.location){const{file:i,line:s,column:a}=e.location;A+=`
                                                                                                                                                                                                               
                                                                                                                                                                                                               
                                                                                                                                                                                                               
                                                                                                                                                                                                               


TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
    at bt (C:\Users\tj_co\source\repos\paratext-bible-extensions\node_modules\tsx\dist\index-971a6964.cjs:16:1598)
    at C:\Users\tj_co\source\repos\paratext-bible-extensions\node_modules\tsx\dist\index-971a6964.cjs:17:423
    at cr (C:\Users\tj_co\source\repos\paratext-bible-extensions\node_modules\tsx\dist\index-971a6964.cjs:16:913)
    at Object.hr [as transformSync] (C:\Users\tj_co\source\repos\paratext-bible-extensions\node_modules\tsx\dist\index-971a6964.cjs:17:348)
    at Object.S (C:\Users\tj_co\source\repos\paratext-bible-extensions\node_modules\tsx\dist\cjs\index.cjs:1:1230)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at cjsLoader (node:internal/modules/esm/translators:356:17)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:305:7)
    at ModuleJob.run (node:internal/modules/esm/module_job:218:25)

Node.js v20.11.1

This change is Reviewable

@tjcouch-sil tjcouch-sil enabled auto-merge March 6, 2024 23:24
Copy link
Contributor

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tjcouch-sil)

@tjcouch-sil tjcouch-sil merged commit 023b085 into main Mar 7, 2024
3 checks passed
@tjcouch-sil tjcouch-sil deleted the implement-editor branch March 7, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants