Aburkut/back 1791 aave stata v2 #868
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackieJoo
reviewed
Dec 19, 2024
JackieJoo
reviewed
Dec 19, 2024
JackieJoo
reviewed
Dec 19, 2024
JackieJoo
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Next tokens are missing, is this on purpose?
[
{
"chainId": 1,
"address": "0x1E6bb68Acec8fefBD87D192bE09bb274170a0548",
"name": "Aave interest bearing AMPL",
"decimals": 9,
"symbol": "aAMPL",
"tags": [
"aTokenV2",
"aaveV2"
],
"logoURI": "https://raw.githubusercontent.com/bgd-labs/web3-icons/main/icons/full/aampl.svg",
"extensions": {
"pool": "0x7d2768dE32b0b80b7a3454c06BdAc94A69DDc7A9",
"underlying": "0xD46bA6D942050d489DBd938a2C909A5d5039A161"
}
},
{
"chainId": 1,
"address": "0x683923dB55Fead99A79Fa01A27EeC3cB19679cC3",
"name": "Aave interest bearing FEI",
"decimals": 18,
"symbol": "aFEI",
"tags": [
"aTokenV2",
"aaveV2"
],
"logoURI": "https://raw.githubusercontent.com/bgd-labs/web3-icons/main/icons/full/afei.svg",
"extensions": {
"pool": "0x7d2768dE32b0b80b7a3454c06BdAc94A69DDc7A9",
"underlying": "0x956F47F50A910163D8BF957Cf5846D573E7f87CA"
}
}
]
There was a problem hiding this comment.
@KanievskyiDanylo Could you please tag @sakulstra ?
There was a problem hiding this comment.
Removed them on purpose. Is custom implementations that are essentially broken
| depositToAave: boolean, | ||
| ]; | ||
|
|
||
| export type RedeemParams = [ |
There was a problem hiding this comment.
not exported, as well as DepositParams
| @@ -0,0 +1,63 @@ | |||
| import { Address } from '../../types'; | |||
|
|
|||
| export type PoolState = {}; | |||
Comment on lines
+216
to
+220
| const cached = await this.dexHelper.cache.get( | ||
| this.dexKey, | ||
| this.network, | ||
| `state_${stataAddressLower}`, | ||
| ); |
There was a problem hiding this comment.
It makes RPC call only once per block, considering that this swap is available only for the limited amount of tokens, do we really need to use cache here? just because for me it looks simples to use RPC call and store locally without touching cache at all
| @@ -0,0 +1,494 @@ | |||
| import { AsyncOrSync } from 'ts-essentials'; | |||
| extends SimpleExchange | ||
| implements IDex<AaveV3StataV2Data> | ||
| { | ||
| readonly hasConstantPriceLargeAmounts = false; |
There was a problem hiding this comment.
I think we can put it as true
// This is true if the the DEX is simply
// wrapping/ unwrapping like weth, lending pools, etc
// or has a pool where arbitrarily large amounts has
// constant price.
readonly hasConstantPriceLargeAmounts: boolean;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #856