Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic nix flake #410

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add basic nix flake #410

wants to merge 2 commits into from

Conversation

Juanperias
Copy link

this pull request adds a fairly simple nix flake that meets the needs of having the rust toolchain installed, plus it adds a rust-toolchain.toml file that includes the wasm and android targets.

you can use the flake with:

nix develop

@parasyte
Copy link
Owner

parasyte commented Jan 2, 2025

Hi. The concern I have for this is that the toolchain file locks the project to the stable release channel. Our CI is setup to build and test with multiple channels. The existence of the toolchain file will override the toolchains used in the CI jobs.

And I don't know if there is a way to "override the override". Let alone getting into situations where you have to override the override for the override. It's best to just not force an override in the first place.


Other than that, I don't use nix. I cannot fully appreciate any benefits that this PR is adding. pixels is just a library with infrequent releases. The dependents are going to lock the specific version they are using. It's unclear to me how nix fits in, or why a secondary package manager is needed.

I guess I'm indifferent to the nix configuration. It's kind of like committing a VS Code project file or something. Just unused files in the repo that make the file list longer.

@Juanperias
Copy link
Author

Hi, thanks for commenting, I have made some changes to avoid some problems, in this case and the most important is to remove the rust-toolchain to avoid problems with the CI.

I understand your point of not understanding the need to use Nix, in my case it was because I wanted to contribute to this project, and I created this simple flake to have the rust toolchain, so I think it could be useful for other Nix users who want to contribute to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants