W-6115601 Update all functions to use Authorization header #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2019 10:53
|
Fixes Issue #39 |
adelawalla
reviewed
May 6, 2019
spec/support/fakeweb.rb
Outdated
| end | ||
|
|
||
| def fake_get path, response | ||
| FakeWeb.register_uri(:get, "https://pi.pardot.com#{path}", :body => response) | ||
| FakeWeb.register_uri(:get, "https://pi.pardot.com#{path}", :body => response, :Authorization => 'user_key=bar&api_key=my_api_key') |
There was a problem hiding this comment.
Shouldn't these have Pardot at the front of the string?
There was a problem hiding this comment.
FakeWeb doesn't support matching based on Authorization so these values weren't being used. I've removed them in the latest.
adelawalla
approved these changes
May 6, 2019
ghost
merged commit
dyroffk
added a commit
to Vidyard/ruby-pardot
that referenced
this pull request
Jan 25, 2021
* properly escape url entities passed into the url * W-5653730: Change to pass auth parameters in body. Passing parameters using query string to auth is deprecated. * W-6115601 Update all functions to use Authorization header (pardot#40) Update calls to use Authorization header instead of query string * Updating version number * add custom fields * update readme * [W-7879842] Update httparty and rspec versions (pardot#51) * PR lint suggestions * Fix merge error around smooth_params Co-authored-by: ted <[email protected]> Co-authored-by: Jared <[email protected]> Co-authored-by: Justin Roberts <[email protected]> Co-authored-by: Adil Delawalla <[email protected]> Co-authored-by: bentona <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the Pardot Ruby Client to use Authorization to authenticate with the Pardot API instead of passing the
user_keyandapi_keyas query string parameters.