This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Set test crates to nopublish and organise metadata #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morganamilo
added
B0-silent
coderobe
approved these changes
Aug 9, 2023
ggwpez
reviewed
Aug 9, 2023
| authors = ["Parity Technologies <[email protected]>"] | ||
| edition = "2021" | ||
| repository = "https://github.com/paritytech/parity-bridges-common/" | ||
| license = "GPL-3.0-or-later WITH Classpath-exception-2.0" |
There was a problem hiding this comment.
I am not sure if we can change the license like this. The classpath exception can be quite important for downstream projects.
There was a problem hiding this comment.
Node side with should be GPL with classpath exception and runtime Apache 2.0.
ggwpez
suggested changes
Aug 14, 2023
Comment on lines
+6
to
+7
| repository.workspace = true | ||
| license.workspace = true |
There was a problem hiding this comment.
We actually cant do this in the light of the monorepo, since Substrate, Polkadot and Cumulus dont have the same repos (and possibly license).
Same applies to paritytech/polkadot#7578, but it already merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.