Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EngAut] RFCs Referenda status tracker / notifications #2

Closed
3 tasks done
mordamax opened this issue Dec 7, 2023 · 9 comments
Closed
3 tasks done

[EngAut] RFCs Referenda status tracker / notifications #2

mordamax opened this issue Dec 7, 2023 · 9 comments
Assignees

Comments

@mordamax
Copy link
Collaborator

mordamax commented Dec 7, 2023

Background polkadot-fellows/RFCs#57

Goal
To increase the interaction and/or awareness in the context of RFC PR for the ongoing referendum status

Desired outcome:
Author and commenters of RFC PR are notified about the Submitted or Confirmed [rejected/approved] status changes of Referendum related to this PR

Solution
implement a periodical tracker, which can scan subsquare collectives referendums, store the statues and map them to existing PRs in polkadot-fellows/RFCs

  • when new referendum (related to this PR) is submitted - post a link to subsquare as a new comment (status Submitted)
  • when the existing referendum (prelated to this PR) changed in its status - post a status change and link as new comment. (Post only if status changed to Confirmed with the according outcome - approved/rejected)

Tasks

  1. Bullrich
  2. Bullrich
@rzadp
Copy link

rzadp commented Dec 7, 2023

As a bonus, we will be able to automatically trigger rfc-action in order to close/merge PRs.

@mordamax mordamax changed the title RFCs Referenda status tracker / notifications [EngAut] RFCs Referenda status tracker / notifications Dec 7, 2023
@mordamax
Copy link
Collaborator Author

mordamax commented Dec 7, 2023

As a bonus, we will be able to automatically trigger rfc-action in order to close/merge PRs.

great idea! I'd plan though after few successful (or not 🥲) runs to make sure it identifies correctly etc ))

@mordamax
Copy link
Collaborator Author

Last week @Bullrich added new cron job which tracks only newly posted proposals paritytech/rfc-action#28. The other statuses will be implemented lated in #4

@Bullrich
Copy link

First part of the task has been completed:

RFC-Action has been updated to contain a cron job, and this cron job tracks ongoing referendas and post them in open PRs if it is related.

Related issues

@mordamax
Copy link
Collaborator Author

mordamax commented Feb 2, 2024

weekly update: no updates this week

@Bullrich
Copy link

Added PR to track completed referendas:

@Bullrich
Copy link

@Bullrich
Copy link

Created new PR to update the correct action (I updated the wrong action):

@mordamax
Copy link
Collaborator Author

image

🚀

Thanks @Bullrich!

@github-project-automation github-project-automation bot moved this from Open to Closed in Parity Roadmap Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants