Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cron job to comment ongoing referenda on PRs #28

Merged
merged 36 commits into from
Jan 19, 2024
Merged

Conversation

Bullrich
Copy link
Contributor

Added functionality for a cron job to iterate over all ongoing referendas and compare them to the open PRs. If there is any match on the remark, and the referenda has been opened after the last time the action was run, it will comment a link to the referenda in Polkassembly.

This is intended to resolve the requirements in polkadot-fellows/RFCs#57

@Bullrich Bullrich requested a review from rzadp January 17, 2024 10:44
@Bullrich Bullrich self-assigned this Jan 17, 2024
src/rfc-cron.ts Outdated Show resolved Hide resolved
src/rfc-cron.ts Outdated Show resolved Hide resolved
@mordamax
Copy link

@Bullrich is it only for new referendas?
can it track the existing referendas status changes as it's requested in paritytech/eng-automation#2

@Bullrich
Copy link
Contributor Author

@Bullrich is it only for new referendas? can it track the existing referendas status changes as it's requested in paritytech/eng-automation#2

Not yet, this first version will only obtain the status of ongoing referendas. After this I can make a second PR handling completed referendas

Copy link

@mordamax mordamax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see it working for a several days on stg before implementation
How you think the further referenda status changes will be tracked?

@Bullrich Bullrich marked this pull request as ready for review January 17, 2024 16:18
@Bullrich Bullrich requested a review from a team as a code owner January 17, 2024 16:18
@Bullrich Bullrich requested a review from rzadp January 17, 2024 16:18
@Bullrich
Copy link
Contributor Author

Hi @rzadp! It is ready for review.

I don't really know what tests I can add aside from ensuring that it doesn't crash when fetching the referenda. If you have any suggestions, please, let me know.

@Bullrich
Copy link
Contributor Author

Bullrich commented Jan 17, 2024

Would love to see it working for a several days on stg before implementation

Me too. Do you know how to setup an alternative testing environment so I can start testing it?

How you think the further referenda status changes will be tracked?

You mean when they close? It should be doable using @rzadp's method, so the logic wouldn't change too much.

@mordamax
Copy link

Do you know how to setup an alternative testing environment so I can start testing it?

answered in our matrix channel - could be Westend -> Collectives with making us fellows there installed to paritytech-stg?

You mean when they close?

as described here paritytech/eng-automation#2

README.md Outdated Show resolved Hide resolved
@Bullrich Bullrich requested a review from rzadp January 19, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants