Backport XCM fixes to 1.4.0

.github/workflows/fmt-check.yml

@@ -15,7 +15,7 @@ jobs:
         os: ["ubuntu-latest"]
     runs-on: ${{ matrix.os }}
     container:
-      image: paritytech/ci-unified:bullseye-1.73.0-2023-11-01-v20231025
+      image: docker.io/paritytech/ci-unified:bullseye-1.75.0-2024-01-22-v20240109
     steps:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
 

.gitlab-ci.yml

@@ -21,7 +21,8 @@ workflow:
     - if: $CI_COMMIT_BRANCH
 
 variables:
-  CI_IMAGE: !reference [.ci-unified, variables, CI_IMAGE]
+  # CI_IMAGE: !reference [.ci-unified, variables, CI_IMAGE]
+  CI_IMAGE: "docker.io/paritytech/ci-unified:bullseye-1.75.0-2024-01-22-v20240109"
   # BUILDAH_IMAGE is defined in group variables
   BUILDAH_COMMAND: "buildah --storage-driver overlay2"
   RELENG_SCRIPTS_BRANCH: "master"
@@ -230,7 +231,7 @@ include:
   stage: .post
   rules:
     - if: $CI_COMMIT_REF_NAME =~ /^[0-9]+$/ # PRs
-      when: on_failure
+      when: never
   variables:
     PROJECT_ID: "${CI_PROJECT_ID}"
     PROJECT_NAME: "${CI_PROJECT_NAME}"
@@ -245,6 +246,7 @@ remove-cancel-pipeline-message:
   stage: .post
   rules:
     - if: $CI_COMMIT_REF_NAME =~ /^[0-9]+$/ # PRs
+      when: never
   variables:
     PROJECT_ID: "${CI_PROJECT_ID}"
     PROJECT_NAME: "${CI_PROJECT_NAME}"

.gitlab/pipeline/build.yml

@@ -14,7 +14,7 @@ build-linux-stable:
     RUST_TOOLCHAIN: stable
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
     # Ensure we run the UI tests.
     RUN_UI_TESTS: 1
   script:
@@ -169,7 +169,7 @@ build-linux-stable-cumulus:
   variables:
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     - echo "___Building a binary, please refrain from using it in production since it goes with the debug assertions.___"
     - time cargo build --release --locked -p polkadot-parachain-bin --bin polkadot-parachain
@@ -189,7 +189,7 @@ build-test-parachain:
   variables:
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     - echo "___Building a binary, please refrain from using it in production since it goes with the debug assertions.___"
     - time cargo build --release --locked -p cumulus-test-service --bin test-parachain

.gitlab/pipeline/test.yml

@@ -16,7 +16,7 @@ test-linux-stable:
     RUST_TOOLCHAIN: stable
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   parallel: 3
   script:
     # Build all but only execute 'runtime' tests.
@@ -66,7 +66,7 @@ test-linux-stable-runtime-benchmarks:
     RUST_TOOLCHAIN: stable
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     - time cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet
 
@@ -81,7 +81,7 @@ test-linux-stable-runtime-benchmarks:
 #     RUST_TOOLCHAIN: stable
 #     # Enable debug assertions since we are running optimized builds for testing
 #     # but still want to have debug assertions.
-#     RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+#     RUSTFLAGS: "-Cdebug-assertions=y"
 #   parallel: 3
 #   script:
 #     # Build all but only execute 'runtime' tests.
@@ -108,7 +108,7 @@ test-linux-stable-additional-tests:
     RUST_TOOLCHAIN: stable
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     # tests were moved to test-linux-stable
     # the jobs should be removed
@@ -128,7 +128,7 @@ test-linux-stable-slow:
     RUST_TOOLCHAIN: stable
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     # tests were moved to test-linux-stable
     # the jobs should be removed
@@ -148,7 +148,7 @@ test-linux-stable-slow:
 #     RUST_TOOLCHAIN: stable
 #     # Enable debug assertions since we are running optimized builds for testing
 #     # but still want to have debug assertions.
-#     RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+#     RUSTFLAGS: "-Cdebug-assertions=y"
 #   script:
 #     - mkdir -p artifacts
 #     - time cargo test --workspace
@@ -169,7 +169,7 @@ test-doc:
   variables:
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     - time cargo test --doc --workspace
 
@@ -207,7 +207,7 @@ test-node-metrics:
     RUST_TOOLCHAIN: stable
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings"
+    RUSTFLAGS: "-Cdebug-assertions=y"
   script:
     # Build the required workers.
     - cargo build --bin polkadot-execute-worker --bin polkadot-prepare-worker --profile testnet --verbose --locked
@@ -326,10 +326,10 @@ test-frame-ui:
   variables:
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-C debug-assertions -D warnings"
+    RUSTFLAGS: "-C debug-assertions"
     RUST_BACKTRACE: 1
     WASM_BUILD_NO_COLOR: 1
-    WASM_BUILD_RUSTFLAGS: "-C debug-assertions -D warnings"
+    WASM_BUILD_RUSTFLAGS: "-C debug-assertions"
     # Ensure we run the UI tests.
     RUN_UI_TESTS: 1
   script:
@@ -347,10 +347,10 @@ quick-benchmarks:
   variables:
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-C debug-assertions -D warnings"
+    RUSTFLAGS: "-C debug-assertions"
     RUST_BACKTRACE: "full"
     WASM_BUILD_NO_COLOR: 1
-    WASM_BUILD_RUSTFLAGS: "-C debug-assertions -D warnings"
+    WASM_BUILD_RUSTFLAGS: "-C debug-assertions"
   script:
     - time cargo run --locked --release -p staging-node-cli --bin substrate-node --features runtime-benchmarks -- benchmark pallet --execution wasm --wasm-execution compiled --chain dev --pallet "*" --extrinsic "*" --steps 2 --repeat 1
 
@@ -387,10 +387,10 @@ test-linux-stable-int:
   variables:
     # Enable debug assertions since we are running optimized builds for testing
     # but still want to have debug assertions.
-    RUSTFLAGS: "-C debug-assertions -D warnings"
+    RUSTFLAGS: "-C debug-assertions"
     RUST_BACKTRACE: 1
     WASM_BUILD_NO_COLOR: 1
-    WASM_BUILD_RUSTFLAGS: "-C debug-assertions -D warnings"
+    WASM_BUILD_RUSTFLAGS: "-C debug-assertions"
     # Ensure we run the UI tests.
     RUN_UI_TESTS: 1
   script:
@@ -439,7 +439,7 @@ cargo-check-each-crate:
     - .run-immediately
     # - .collect-artifacts
   variables:
-    # $CI_JOB_NAME is set manually so that rusty-cachier can share the cache for all
+    # $CI_JOB_NAME is set manually so that cache could be shared for all jobs
     # "cargo-check-each-crate I/N" jobs
     CI_JOB_NAME: cargo-check-each-crate
   timeout: 2h