Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc server: listen to
ipv6 socket
if available and--experimental-rpc-endpoint
CLI option #4792rpc server: listen to
ipv6 socket
if available and--experimental-rpc-endpoint
CLI option #4792Changes from 1 commit
12c57c9
0aadd3d
15691d6
f681f0e
bd74645
88a7c00
369db7e
fa8cda3
a2418a2
5f62b6e
a2e6e07
489a598
f3df0da
0b0cabe
0237951
0f90c4e
3115029
d969257
f0bd8b2
0477b67
1b4c2d3
cc98347
d1ddf14
66b64c8
a3e5f52
0eb3e5f
11a871f
c564cdc
b8e575c
8b8b083
7e1c30e
9122ba7
fdd335e
5b1f5ff
3e78406
d08985a
42bc717
5d0afcd
245f265
4ea49af
d16b0bd
9fc691a
6073e86
8fb416e
7c7f8e3
270f178
811dfa4
ce6c96f
738f435
e68f05f
a4e01a0
e1394e2
32be5a2
2ecbafd
799e3e0
d2e0844
e452047
2f663ea
0bb4871
9d593c3
3827211
a4dec4e
9ddaf45
4ede846
a4ec638
829e9ca
c7a100e
12e27fc
46671b4
0857baa
bb8a039
ecd1146
f490e7b
f2d90d0
304036e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//cc @BulatSaif @PierreBesson I haven't introduced any flag such as
--unsafe-external
and--external
here, it's up to the user to define such a thing by the listen-addr but I added a similar warning log.Do you want extra flags for that anyway?
Now one need to do:
--rpc-endpoint "listen-addr=0.0.0.0:9944,methods=unsafe"
but we could add something extra such as option for
--rpc-endpoint "listen-addr=0.0.0.0:9944,methods=unsafe,unsafe-external=true"
but I don't see how that could make things better though...