Add assets in pool with native to query_acceptable_payment_assets's return #5599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscoaguirre
added
the
A4-needs-backport
acatangiu
approved these changes
Sep 17, 2024
bkontur
reviewed
Oct 14, 2024
Co-authored-by: Branislav Kontur <[email protected]>
5 tasks
bkontur
reviewed
Oct 15, 2024
cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
bkontur
approved these changes
Oct 15, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…eturn (#5599) `XcmPaymentApi::query_acceptable_payment_assets` is an API that returns the assets that can be used to pay fees on the runtime where it's called. For relays and most system chains this was configured only as the native asset: ROC and WND. However, the asset hubs have the asset conversion pallet, which allows fees to be paid in any asset in a pool with the native one. This PR adds the list of assets in a pool with the native one to the return value of this API for the asset hubs. --------- Co-authored-by: Branislav Kontur <[email protected]> (cherry picked from commit d2ba567)
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…eturn (#5599) `XcmPaymentApi::query_acceptable_payment_assets` is an API that returns the assets that can be used to pay fees on the runtime where it's called. For relays and most system chains this was configured only as the native asset: ROC and WND. However, the asset hubs have the asset conversion pallet, which allows fees to be paid in any asset in a pool with the native one. This PR adds the list of assets in a pool with the native one to the return value of this API for the asset hubs. --------- Co-authored-by: Branislav Kontur <[email protected]> (cherry picked from commit d2ba567)
|
Successfully created backport PR for |
franciscoaguirre
added a commit
that referenced
this pull request
Oct 15, 2024
Backport #5599 into `stable2409` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Francisco Aguirre <[email protected]>
|
@franciscoaguirre, do you plan to adjust the implementation of the |
|
Yes, coming right up! |
|
Wrote a draft: #6080 |
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 25, 2024
…paritytech#6080) A follow-up to paritytech#5599. Assets in a pool with the native one are returned from `query_acceptable_payment_assets`. Now those assets can be used in `query_weight_to_asset_fee` to get the correct amount that needs to be paid. --------- Co-authored-by: command-bot <>
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 25, 2024
…paritytech#6080) A follow-up to paritytech#5599. Assets in a pool with the native one are returned from `query_acceptable_payment_assets`. Now those assets can be used in `query_weight_to_asset_fee` to get the correct amount that needs to be paid. --------- Co-authored-by: command-bot <>
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 25, 2024
…paritytech#6080) A follow-up to paritytech#5599. Assets in a pool with the native one are returned from `query_acceptable_payment_assets`. Now those assets can be used in `query_weight_to_asset_fee` to get the correct amount that needs to be paid. --------- Co-authored-by: command-bot <>
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 25, 2024
…paritytech#6080) A follow-up to paritytech#5599. Assets in a pool with the native one are returned from `query_acceptable_payment_assets`. Now those assets can be used in `query_weight_to_asset_fee` to get the correct amount that needs to be paid. --------- Co-authored-by: command-bot <>
franciscoaguirre
added a commit
that referenced
this pull request
Oct 25, 2024
Backport #5599 into `stable2407` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Francisco Aguirre <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Shawn Tabrizi <[email protected]>
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 25, 2024
…paritytech#6080) A follow-up to paritytech#5599. Assets in a pool with the native one are returned from `query_acceptable_payment_assets`. Now those assets can be used in `query_weight_to_asset_fee` to get the correct amount that needs to be paid. --------- Co-authored-by: command-bot <>
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 29, 2024
…paritytech#6080) A follow-up to paritytech#5599. Assets in a pool with the native one are returned from `query_acceptable_payment_assets`. Now those assets can be used in `query_weight_to_asset_fee` to get the correct amount that needs to be paid. --------- Co-authored-by: command-bot <>
mordamax
pushed a commit
to paritytech-stg/polkadot-sdk
that referenced
this pull request
Oct 29, 2024
…paritytech#6080) A follow-up to paritytech#5599. Assets in a pool with the native one are returned from `query_acceptable_payment_assets`. Now those assets can be used in `query_weight_to_asset_fee` to get the correct amount that needs to be paid. --------- Co-authored-by: command-bot <>
franciscoaguirre
added a commit
that referenced
this pull request
Nov 6, 2024
…#6080) A follow-up to #5599. Assets in a pool with the native one are returned from `query_acceptable_payment_assets`. Now those assets can be used in `query_weight_to_asset_fee` to get the correct amount that needs to be paid. --------- Co-authored-by: command-bot <> (cherry picked from commit b4732ad)
franciscoaguirre
added a commit
that referenced
this pull request
Nov 8, 2024
…#6080) A follow-up to #5599. Assets in a pool with the native one are returned from `query_acceptable_payment_assets`. Now those assets can be used in `query_weight_to_asset_fee` to get the correct amount that needs to be paid. --------- Co-authored-by: command-bot <> (cherry picked from commit b4732ad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XcmPaymentApi::query_acceptable_payment_assetsis an API that returns the assets that can be used to pay fees on the runtime where it's called.For relays and most system chains this was configured only as the native asset: ROC and WND.
However, the asset hubs have the asset conversion pallet, which allows fees to be paid in any asset in a pool with the native one.
This PR adds the list of assets in a pool with the native one to the return value of this API for the asset hubs.