Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Remove duplicate jobs #5602

Merged
merged 7 commits into from
Sep 9, 2024
Merged

[CI] Remove duplicate jobs #5602

merged 7 commits into from
Sep 9, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Sep 5, 2024

All of these things are already tested in Github Actions:

polkadot-sdk/.github/workflows/checks-quick.yml

Line 50 in b3c2a25

check-rust-feature-propagation:

Q: the job-starter seems to be used by tests, so am keeping it, but not sure how useful it is.

@ggwpez ggwpez requested a review from a team as a code owner September 5, 2024 11:21
@ggwpez ggwpez added the R0-silent Changes should not be mentioned in any release notes label Sep 5, 2024
alvicsam
alvicsam approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@alvicsam alvicsam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! job-starter is still needed for few other jobs. Are we going to make all the jobs required in checks-quick.yml? I can add a final step like here and make it required

@paritytech-review-bot paritytech-review-bot bot requested a review from a team September 5, 2024 11:40
@ggwpez
Copy link
Member Author

ggwpez commented Sep 5, 2024

Thanks! job-starter is still needed for few other jobs. Are we going to make all the jobs required in checks-quick.yml? I can add a final step like here and make it required

Screenshot 2024-09-05 at 17 14 55

Yes sounds good. They are already required, but their gitlab version instead of GH.

@alvicsam alvicsam requested a review from a team as a code owner September 5, 2024 15:32
@alvicsam
Copy link
Contributor

alvicsam commented Sep 5, 2024

They are already required, but their gitlab version instead of GH.

Yep, will change during merge of this PR

@ggwpez
Copy link
Member Author

ggwpez commented Sep 6, 2024

@alvicsam i think this one is still required: continuous-integration/gitlab-test-rust-features and blocking the MR currently

@alvicsam alvicsam added this pull request to the merge queue Sep 9, 2024
Merged via the queue into master with commit a3eda0a Sep 9, 2024
201 of 203 checks passed
@alvicsam alvicsam deleted the oty-ci-remove-duplicates branch September 9, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvicsam alvicsam alvicsam approved these changes

@AndWeHaveAPlan AndWeHaveAPlan AndWeHaveAPlan approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@mordamax mordamax mordamax approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ggwpez @alvicsam @mordamax @EgorPopelyaev @AndWeHaveAPlan