-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pallet-revive] eth-prc fix geth diff #6608
Open
pgherveou
wants to merge
21
commits into
master
Choose a base branch
from
pg/fix-geth-diff
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgherveou
force-pushed
the
pg/fix-geth-diff
branch
from
November 22, 2024 14:46
c434487
to
1f069da
Compare
pgherveou
force-pushed
the
pg/fix-geth-diff
branch
from
November 26, 2024 13:10
1f069da
to
716f40a
Compare
/cmd prdoc --audience runtime_dev --bump minor |
pgherveou
added
T7-smart_contracts
This PR/Issue is related to smart contracts.
R0-silent
Changes should not be mentioned in any release notes
labels
Nov 26, 2024
All GitHub workflows were cancelled due to failure one of the required jobs. |
pgherveou
commented
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
R0-silent
Changes should not be mentioned in any release notes
T7-smart_contracts
This PR/Issue is related to smart contracts.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geth
EVM RPC server will not fail gas_estimation if no gas is specified, I updated pallet-revive to add an extra
skip_transfer
boolean check to replicate this behavior in our palleteth_transact
andbare_eth_transact
api have been updated to useGenericTransaction
directly as this is what is used byeth_estimateGas
andeth_call
TODO
skip_transfer
flag