Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pallet-revive] eth-prc fix geth diff #6608

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Nov 22, 2024

  • Add a bunch of differential tests to ensure that responses from eth-rpc matches the one from geth
    • These tests are not run in CI for now but can be run locally with
cd revive/rpc/examples/js
bun test
  • EVM RPC server will not fail gas_estimation if no gas is specified, I updated pallet-revive to add an extra skip_transfer boolean check to replicate this behavior in our pallet

  • eth_transact and bare_eth_transact api have been updated to use GenericTransaction directly as this is what is used by eth_estimateGas and eth_call

TODO

  • Add tests the new skip_transfer flag

@pgherveou pgherveou marked this pull request as ready for review November 26, 2024 15:57
@pgherveou
Copy link
Contributor Author

/cmd prdoc --audience runtime_dev --bump minor

@pgherveou pgherveou added T7-smart_contracts This PR/Issue is related to smart contracts. R0-silent Changes should not be mentioned in any release notes labels Nov 26, 2024
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12034465218
Failed job name: test-linux-stable-runtime-benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants