Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating pallet-state-trie-migration to benchmarking V2 #6617

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Migrating pallet-state-trie-migration to benchmarking V2 #6617

merged 4 commits into from
Nov 28, 2024

Conversation

Krayt78
Copy link
Contributor

@Krayt78 Krayt78 commented Nov 22, 2024

Description

Migrated pallet-state-trie-migration benchmarking to the new benchmarking syntax v2.
This is part of #6202

@Krayt78 Krayt78 requested review from cheme and a team as code owners November 22, 2024 20:30
@Krayt78 Krayt78 mentioned this pull request Nov 22, 2024
Open
43 tasks
shawntabrizi
shawntabrizi approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about all the added semicolons, but update looks good

@Krayt78
Copy link
Contributor Author

Krayt78 commented Nov 25, 2024

not sure about all the added semicolons, but update looks good

They have been added by rustfmt, i think i have the default config file for it, can change it if u want.
https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=#trailing_semicolon

@shawntabrizi
Copy link
Member

if rustfmt added it, then all good :)

@re-gius re-gius added R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Nov 28, 2024
@shawntabrizi shawntabrizi added this pull request to the merge queue Nov 28, 2024
@re-gius
Copy link
Contributor

re-gius commented Nov 28, 2024

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@Krayt78 Contributor did not properly post their account address.

Make sure the pull request description (or user bio) has: "{network} address: {address}".

@re-gius
Copy link
Contributor

re-gius commented Nov 28, 2024 •
edited
Loading

@Krayt78 add your Polkadot address to your bio to get a small DOT tip (one every two completed PRs on this issue) and then ping me

Merged via the queue into paritytech:master with commit fdb264d Nov 28, 2024
166 of 171 checks passed
@Krayt78
Copy link
Contributor Author

Krayt78 commented Nov 28, 2024

@Krayt78 add your Polkadot address to your bio to get a small DOT tip (one every two completed PRs on this issue) and then ping me

Done !

@re-gius
Copy link
Contributor

re-gius commented Nov 28, 2024

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@re-gius A referendum for a small (20 DOT) tip was successfully submitted for @Krayt78 (14AgwoPjcRiEEJgjfHmvAqkjdERCG26WEvQUoGLuBzcXKMS2 on polkadot).

Referendum number: 1320.
tip

@substrate-tip-bot substrate-tip-bot
Copy link

The referendum has appeared on Polkassembly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@re-gius re-gius re-gius approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@cheme cheme Awaiting requested review from cheme cheme is a code owner

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Krayt78 @shawntabrizi @re-gius