xcm: fix local/remote exports when inner routers return NotApplicable
#6645
+248
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
added
R0-silent
bkontur
added
the
A4-needs-backport
|
/cmd fmt |
|
Command "fmt" has started 🚀 See logs here |
|
Command "fmt" has finished ✅ See logs here |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
acatangiu
approved these changes
Nov 26, 2024
franciscoaguirre
approved these changes
Nov 26, 2024
|
/cmd prdoc --audience runtime_dev --bump patch |
bkontur
commented
Nov 26, 2024
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6645-to-stable2407
git worktree add --checkout .worktree/backport-6645-to-stable2407 backport-6645-to-stable2407
cd .worktree/backport-6645-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 1c0b610078611dfebc082be52e77109ea4517e48
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6645-to-stable2409
git worktree add --checkout .worktree/backport-6645-to-stable2409 backport-6645-to-stable2409
cd .worktree/backport-6645-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 1c0b610078611dfebc082be52e77109ea4517e48
git push --force-with-lease |
bkontur
added a commit
that referenced
this pull request
Nov 26, 2024
…e` (#6645) This PR addresses two small fixes: 1. Fixed a typo ("as as") found on the way. 2. Resolved a bug in the `local/remote exporters` used for bridging. Previously, they consumed `dest` and `msg` without returning them when inner routers/exporters failed with `NotApplicable`. This PR ensures compliance with the [`SendXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/src/v5/traits.rs#L449-L450) and [`ExportXcm`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/xcm-executor/src/traits/export.rs#L44-L45) traits. --------- Co-authored-by: GitHub Action <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two small fixes:
local/remote exportersused for bridging. Previously, they consumeddestandmsgwithout returning them when inner routers/exporters failed withNotApplicable. This PR ensures compliance with theSendXcmandExportXcmtraits.TODO: