-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omni-node: --dev sets manual seal and allows --chain to be set #6646
Open
iulianbarbu
wants to merge
11
commits into
paritytech:master
Choose a base branch
from
iulianbarbu:ib-dev-flag-with-manual-seal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
omni-node: --dev sets manual seal and allows --chain to be set #6646
iulianbarbu
wants to merge
11
commits into
paritytech:master
from
iulianbarbu:ib-dev-flag-with-manual-seal
+56
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iulian Barbu <[email protected]>
iulianbarbu
added
T9-cumulus
This PR/Issue is related to cumulus.
T17-Templates
This PR/Issue is related to templates
labels
Nov 26, 2024
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
iulianbarbu
changed the title
omni-node: --dev starts manual seal and allows --chain to be set
omni-node: --dev sets manual seal and allows --chain to be set
Nov 26, 2024
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes a few things:
--dev
flag will not conflict with--chain
anymore, but if--chain
is not given will set--chain=dev
.--dev-block-time
requires--dev
too, and that's to enable the assumed development setup that's configured throughout the codebase when--dev
is present alongside a manual seal based OmniNode.--dev-block-time
is optional and it defaults to 3000ms if not set after setting--dev
.--dev
.Closes: #6537
Integration
Relevant for node/runtime developers that use OmniNode lib, including
polkadot-omni-node
binary, although the recommended way is to usechopsticks
.Review Notes
parachain-template-node
as is (meaning--dev
isn't usable and testing a runtime with theparachain-template-node
still needs a relay chain here). I am doing this because I think we want either way to phase outparachain-template-node
and adding manual seal support for it is wasted effort. We might add support though if the demand is forparachain-template-node
.--dev-block-time
. Also, would want first to align & merge on runtime metadata checks we added in Omni Node here: omni-node: add metadata checks for runtime/parachain compatibility #6450 before starting to infer AURA config slot duration via the same way.