txpool api: remove invalid call improved

[michalkucharczyk]

Currently the transaction which is reported as invalid by a block builder (or removed_invalid by other components) is silently skipped.

This PR improves this behavior. The transaction pool report_invalid function now accepts optional error associated with every reported transaction, and also the optional block hash which provides hints how reported transaction shall be handled. The following API change is proposed:

polkadot-sdk/substrate/client/transaction-pool/api/src/lib.rs

Lines 293 to 310 in 8c8e033

	/// Reports invalid transactions to the transaction pool.
	///
	/// This function accepts an array of tuples, each containing a transaction hash and an
	/// optional error encountered during the transaction execution at a specific (also optional)
	/// block.
	///
	/// The transaction pool implementation decides which transactions to remove. Transactions
	/// dependent on invalid ones will also be removed.
	///
	/// If the tuple's error is None, the transaction will be forcibly removed from the pool.
	///
	/// The optional `at` parameter provides additional context regarding the block where the error
	/// occurred.
	fn report_invalid(
	&self,
	at: Option<<Self::Block as BlockT>::Hash>,
	invalid_tx_errors: &[(TxHash<Self>, Option<sp_blockchain::Error>)],
	) -> Vec<Arc<Self::InPoolTransaction>>;

Depending on error, the transaction pool can decide if transaction shall be removed from the view only or entirely from the pool. Invalid event will be dispatched if required.

fixes: #6008

[michalkucharczyk]

We could also keep old function remove_invalid and add new one, with no optional error/block parameters. Really no strong opinion here.

I also think that triggering invalid event in case of removal the transaction via RPC call is (maybe) undesirable - so maybe we should have pure remove function (which would trigger Dropped, IMO it makes more sense). Any thoughts?

[paritytech-workflow-stopper]

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12036823135
Failed job name: test-linux-stable-no-try-runtime