Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: Fix encoding conversion from utf16 to utf8 #131

Merged
merged 3 commits into from
Dec 11, 2024
Merged

JS: Fix encoding conversion from utf16 to utf8 #131

merged 3 commits into from
Dec 11, 2024

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Dec 9, 2024 •
edited
Loading

Fix encoding conversion from JS string (UTF-16) to UTF-8 used in the rust code.

@smiasojed smiasojed marked this pull request as ready for review December 10, 2024 21:09
xermicus
xermicus approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@xermicus xermicus changed the title Fix encoding conversion from utf16 to utf8 JS: Fix encoding conversion from utf16 to utf8 Dec 11, 2024
@xermicus xermicus merged commit afe44ad into main Dec 11, 2024
3 checks passed
@xermicus xermicus deleted the sm/enc-fix branch December 11, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xermicus xermicus xermicus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smiasojed @xermicus