This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Split SandboxInstance::get_global_val implementation per backend
#11234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x7CFE
added
A0-please_review
0x7CFE
force-pushed
the
dk-split-get_global_val
branch
from
d660c3c to
4e0c807
Compare
kpp
approved these changes
Apr 19, 2022
bkchr
reviewed
Apr 19, 2022
bkchr
approved these changes
Apr 19, 2022
athei
approved these changes
Apr 21, 2022
|
bot merge |
|
Waiting for commit status. |
godcodehunter
pushed a commit
to sensoriumxr/substrate
that referenced
this pull request
Jun 22, 2022
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the
SandboxInstance::get_global_vallogic and moves it to corresponding backend modules.Followup to #10563