Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stream support #8

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Add stream support #8

merged 2 commits into from
Oct 18, 2018

Conversation

futpib
Copy link
Contributor

@futpib futpib commented Oct 16, 2018 •
edited
Loading

@parshap
Copy link
Owner

parshap commented Oct 18, 2018

@futpib: This is excellent! Thank you for adding tests. Can you also update the readme indicating that the file argument may be a string?

@parshap
Copy link
Owner

parshap commented Oct 18, 2018

Excellent, thanks!

@parshap parshap merged commit df590d8 into parshap:master Oct 18, 2018
@parshap
Copy link
Owner

parshap commented Oct 18, 2018

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@futpib @parshap