Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for blockwise requests to complete when connecting to the cloud #2560

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

sergeuz
Copy link
Member

@sergeuz sergeuz commented Oct 19, 2022

Problem

Particle.connected() may return true while the handshake is still in progress if the system/application Describe message is being sent as a blockwise request.

Steps to Test

  • Run unit tests.
  • Run the comms integration tests several times and validate that the 06_register_many_functions and 07_register_many_variables tests no longer fail due to blockwise transfer taking longer to complete.

References

  • sc-107101

@sergeuz sergeuz marked this pull request as draft October 19, 2022 14:06
@avtolstoy avtolstoy force-pushed the wait_for_blockwise_describe/sc-107101 branch from 5d41ddb to 986e832 Compare October 23, 2022 19:43
@avtolstoy avtolstoy mentioned this pull request Oct 24, 2022
6 tasks
@avtolstoy avtolstoy added this to the 5.3.0 milestone Nov 29, 2022
@sergeuz sergeuz force-pushed the wait_for_blockwise_describe/sc-107101 branch from 986e832 to 8dea07e Compare April 21, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants