Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty Printer and Binding evaluation #11

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Pretty Printer and Binding evaluation #11

merged 2 commits into from
Jan 17, 2024

Conversation

yliuuuu
Copy link
Contributor

@yliuuuu yliuuuu commented Jan 17, 2024

Issue #, if available: N/A

Description of changes:
add pretty printer and ability to evaluate binding from string.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Attention: 72 lines in your changes are missing coverage. Please review.

Comparison is base (824031f) 1.72% compared to head (4676500) 0.00%.

Files Patch % Lines
src/pretty.rs 0.00% 43 Missing ⚠️
src/lib.rs 0.00% 29 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #11      +/-   ##
========================================
- Coverage   1.72%   0.00%   -1.73%     
========================================
  Files          1       2       +1     
  Lines         58     119      +61     
  Branches      58     119      +61     
========================================
- Hits           1       0       -1     
- Misses        57     119      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yliuuuu yliuuuu requested a review from am357 January 17, 2024 17:58
Copy link
Contributor

@am357 am357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ one suggestion

src/pretty.rs Show resolved Hide resolved
Co-authored-by: Arash Maymandi <[email protected]>
@yliuuuu yliuuuu merged commit 4014486 into main Jan 17, 2024
8 checks passed
@yliuuuu yliuuuu deleted the for-website branch January 17, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants