Add spec-defined SqlParserTest tests; fix ParseError symbol #10
Conversation
| ] | ||
| }, | ||
| parse::{ | ||
| name: "call SUBSTRING normal syntax", |
There was a problem hiding this comment.
For this and other lines that it applies: by normal do we mean PartiQL syntax? If so, how about changing it?
There was a problem hiding this comment.
Thinking more about this, should we consider porting the sql92, etc. to namespaces?
E.g.:
'sql92'::[
parse::{
...
}
]There was a problem hiding this comment.
Yes, "normal" referred to the PartiQL function call syntax. I can change to use a more specific term.
Thinking more about this, should we consider porting the sql92, etc. to namespaces?
Good suggestion. I will enclose the sql92-related syntax in its own namespace.
There was a problem hiding this comment.
In addition, was wondering if at some point we're planning to have unhappy paths too i.e. ParseError.
Yes, as part of #5, more error tests will be added. This PR just added tests from SqlParserTest.kt which only had passing tests.
| ] | ||
| }, | ||
| parse::{ | ||
| name: "call SUBSTRING normal syntax", |
There was a problem hiding this comment.
Yes, "normal" referred to the PartiQL function call syntax. I can change to use a more specific term.
Thinking more about this, should we consider porting the sql92, etc. to namespaces?
Good suggestion. I will enclose the sql92-related syntax in its own namespace.
| ] | ||
| }, | ||
| ], | ||
| 'function-argument-list'::[ |
There was a problem hiding this comment.
Thanks for breaking these down, since we'll likely going to have a similar pattern in other tests (E.g. sql92 vs. sql2011 vs. partiql), does it make sense to rename such namespaces (E.g. function-argument-list) to partiql?
There was a problem hiding this comment.
Ok, sure I can change it to the partiql namespace.
Part of #5.
Adds tests from the latest commit of SqlParserTests.kt.
SqlParserTests.ktis one of the larger files with parser tests. Omits some tests that are not part of the current spec (e.g. DML, DDL,LETclause) along with some other tests (full details in this issue comment).Also, fixes an error in the parse error assertion result.
ParserError->ParseError.I verified the new test files are parseable using the Rust test runner created in partiql/partiql-lang-rust#75.
In total, will now have 163 tests (up from 15 previously).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.