Fix line numbers, fixes #6

parttimenerd · Dec 1, 2023 · f5ed64e · f5ed64e
1 parent 2b53935
commit f5ed64e
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/main/kotlin/me/bechberger/jfrtofp/processor/Tables.kt b/src/main/kotlin/me/bechberger/jfrtofp/processor/Tables.kt
@@ -317,6 +317,7 @@ class FuncTableWrapper(val tables: Tables) {
             resourcess.add(-1)
             fileNames.add(null)
             sourceUrls.add(tables.defaultUrl?.let { tables.getString(it) })
+            lineNumbers.add(-1)
             index
         }
     }
@@ -361,7 +362,10 @@ class FrameTableWrapper(val tables: Tables) {
     internal fun getFrame(
         frame: RecordedFrame
     ): IndexIntoFrameTable {
-        val func = tables.getFunction(frame.method, frame.isJavaFrame, frame.lineNumber)
+        // we don't know the start line of the function from JFR
+        // so we use -1, to signal the profile viewer that it is invalid
+        // Related to https://github.com/parttimenerd/jfrtofp/issues/6
+        val func = tables.getFunction(frame.method, frame.isJavaFrame, -1)
         val line = if (frame.lineNumber == -1) null else frame.lineNumber
 
         return map.computeIfAbsent(func to line) {