remove experimental trace feature

patchlevel · Dec 12, 2024 · b701062 · b701062
1 parent 28b65ef
commit b701062
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 263 deletions.
diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -40,8 +40,7 @@
  *      snapshot_stores: array<string, array{type: string, service: string}>,
  *      migration: array{path: string, namespace: string},
  *      cryptography: array{enabled: bool, algorithm: string},
- *      clock: array{freeze: ?string, service: ?string},
- *      debug: array{trace: bool}
+ *      clock: array{freeze: ?string, service: ?string}
  * }
  */
 final class Configuration implements ConfigurationInterface
@@ -205,13 +204,6 @@ public function getConfigTreeBuilder(): TreeBuilder
                     ->scalarNode('algorithm')->defaultValue('aes256')->end()
                 ->end()
             ->end()
-
-            ->arrayNode('debug')
-                ->addDefaultsIfNotSet()
-                ->children()
-                    ->booleanNode('trace')->defaultFalse()->end()
-                ->end()
-            ->end()
         ->end();
         // @codingStandardsIgnoreEnd
 

diff --git a/src/DependencyInjection/PatchlevelEventSourcingExtension.php b/src/DependencyInjection/PatchlevelEventSourcingExtension.php
@@ -40,9 +40,6 @@
 use Patchlevel\EventSourcing\Console\Command\WatchCommand;
 use Patchlevel\EventSourcing\Console\DoctrineHelper;
 use Patchlevel\EventSourcing\Cryptography\DoctrineCipherKeyStore;
-use Patchlevel\EventSourcing\Debug\Trace\TraceableSubscriberAccessorRepository;
-use Patchlevel\EventSourcing\Debug\Trace\TraceDecorator;
-use Patchlevel\EventSourcing\Debug\Trace\TraceStack;
 use Patchlevel\EventSourcing\EventBus\AttributeListenerProvider;
 use Patchlevel\EventSourcing\EventBus\Consumer;
 use Patchlevel\EventSourcing\EventBus\DefaultConsumer;
@@ -112,7 +109,6 @@
 use Patchlevel\EventSourcingBundle\EventBus\SymfonyEventBus;
 use Patchlevel\EventSourcingBundle\RequestListener\AutoSetupListener;
 use Patchlevel\EventSourcingBundle\RequestListener\SubscriptionRebuildAfterFileChangeListener;
-use Patchlevel\EventSourcingBundle\RequestListener\TraceListener;
 use Patchlevel\EventSourcingBundle\ValueResolver\AggregateRootIdValueResolver;
 use Patchlevel\Hydrator\Cryptography\Cipher\Cipher;
 use Patchlevel\Hydrator\Cryptography\Cipher\CipherKeyFactory;
@@ -166,7 +162,6 @@ public function load(array $configs, ContainerBuilder $container): void
         $this->configureSchema($config, $container);
         $this->configureSubscription($config, $container);
         $this->configureCryptography($config, $container);
-        $this->configureDebugging($config, $container);
         $this->configureMigration($config, $container);
         $this->configureValueResolver($container);
     }
@@ -898,54 +893,6 @@ private function configureCryptography(array $config, ContainerBuilder $containe
         $container->setAlias(PayloadCryptographer::class, PersonalDataPayloadCryptographer::class);
     }
 
-    /** @param Config $config */
-    private function configureDebugging(array $config, ContainerBuilder $container): void
-    {
-        if (!$config['debug']['trace']) {
-            return;
-        }
-
-        $container->register(TraceStack::class);
-
-        $container->register(TraceDecorator::class)
-            ->setArguments([
-                new Reference(TraceStack::class),
-            ])
-            ->addTag('event_sourcing.message_decorator');
-
-        $container->register(TraceableSubscriberAccessorRepository::class)
-            ->setDecoratedService(SubscriberAccessorRepository::class)
-            ->setArguments([
-                new Reference('.inner'),
-                new Reference(TraceStack::class),
-            ]);
-
-        $container->register(TraceListener::class)
-            ->setArguments([
-                new Reference(TraceStack::class),
-            ])
-            ->addTag('kernel.event_listener', [
-                'priority' => 0,
-                'event' => 'console.command',
-                'method' => 'onConsoleCommand',
-            ])
-            ->addTag('kernel.event_listener', [
-                'priority' => 0,
-                'event' => 'console.terminate',
-                'method' => 'onConsoleTerminate',
-            ])
-            ->addTag('kernel.event_listener', [
-                'priority' => 0,
-                'event' => 'kernel.request',
-                'method' => 'onRequest',
-            ])
-            ->addTag('kernel.event_listener', [
-                'priority' => 0,
-                'event' => 'kernel.response',
-                'method' => 'onResponse',
-            ]);
-    }
-
     private function configureValueResolver(ContainerBuilder $container): void
     {
         $container->register(AggregateRootIdValueResolver::class)

diff --git a/src/DependencyInjection/TraceCompilerPass.php b/src/DependencyInjection/TraceCompilerPass.php
diff --git a/src/Messenger/TraceHandlersLocator.php b/src/Messenger/TraceHandlersLocator.php
diff --git a/src/PatchlevelEventSourcingBundle.php b/src/PatchlevelEventSourcingBundle.php
@@ -6,15 +6,13 @@
 
 use Patchlevel\EventSourcingBundle\DependencyInjection\RepositoryCompilerPass;
 use Patchlevel\EventSourcingBundle\DependencyInjection\SubscriberGuardCompilePass;
-use Patchlevel\EventSourcingBundle\DependencyInjection\TraceCompilerPass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
 
 final class PatchlevelEventSourcingBundle extends Bundle
 {
     public function build(ContainerBuilder $container): void
     {
-        $container->addCompilerPass(new TraceCompilerPass());
         $container->addCompilerPass(new RepositoryCompilerPass());
         $container->addCompilerPass(new SubscriberGuardCompilePass());
     }

diff --git a/src/RequestListener/TraceListener.php b/src/RequestListener/TraceListener.php
diff --git a/tests/Unit/PatchlevelEventSourcingBundleTest.php b/tests/Unit/PatchlevelEventSourcingBundleTest.php
@@ -28,7 +28,6 @@
 use Patchlevel\EventSourcing\Console\Command\SubscriptionStatusCommand;
 use Patchlevel\EventSourcing\Console\Command\SubscriptionTeardownCommand;
 use Patchlevel\EventSourcing\Console\Command\WatchCommand;
-use Patchlevel\EventSourcing\Debug\Trace\TraceStack;
 use Patchlevel\EventSourcing\EventBus\DefaultEventBus;
 use Patchlevel\EventSourcing\EventBus\EventBus;
 use Patchlevel\EventSourcing\EventBus\Psr14EventBus;
@@ -938,9 +937,6 @@ public function testCryptography(): void
                     'connection' => [
                         'service' => 'doctrine.dbal.eventstore_connection',
                     ],
-                    'debug' => [
-                        'trace' => true,
-                    ],
                     'cryptography' => [
                         'algorithm' => 'aes256',
                     ],
@@ -951,27 +947,6 @@ public function testCryptography(): void
         self::assertInstanceOf(PersonalDataPayloadCryptographer::class, $container->get(PayloadCryptographer::class));
     }
 
-    public function testTrace(): void
-    {
-        $container = new ContainerBuilder();
-
-        $this->compileContainer(
-            $container,
-            [
-                'patchlevel_event_sourcing' => [
-                    'connection' => [
-                        'service' => 'doctrine.dbal.eventstore_connection',
-                    ],
-                    'debug' => [
-                        'trace' => true,
-                    ],
-                ],
-            ]
-        );
-
-        self::assertInstanceOf(TraceStack::class, $container->get(TraceStack::class));
-    }
-
     public function testFullBuild(): void
     {
         $psrClock = $this->prophesize(ClockInterface::class)->reveal();
@@ -1011,9 +986,6 @@ public function testFullBuild(): void
                     'cryptography' => [
                         'algorithm' => 'aes256',
                     ],
-                    'debug' => [
-                        'trace' => true,
-                    ],
                     'subscription' => [
                         'catch_up' => [
                             'limit' => 10,