Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trace feature which was experimental, deprecate subscriber accessor interface #648

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

DavidBadura
Copy link
Member

SubscriberAccessorInterface was introduced to implement the trace feature. Unfortunately, this feature was not as useful as expected and now makes further development of the subscription engine very difficult. Since the trace feature was only experimental, it can be removed without any problem. I have now deprecated the introduced interface. Since both were not documented, I assume that this change does not affect the developers.

@DavidBadura DavidBadura force-pushed the deprecate-subscriber-accessor-interface branch from 89b09e8 to ab6f783 Compare December 5, 2024 11:56
Copy link

github-actions bot commented Dec 5, 2024

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.067s (±0.00%) | 3.069s (±0.00%) | -0.04%    | 34.734mb        | 34.742mb   | -0.02%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 69.341ms (±0.00%) | 70.047ms (±0.00%) | -1.01%    | 34.234mb        | 34.234mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 919.800μs (±0.00%) | 948.500μs (±0.00%) | -3.03%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchLoad10000Events ()                | 46.856ms (±0.00%)  | 46.767ms (±0.00%)  | +0.19%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave1Event ()                     | 1.022ms (±0.00%)   | 1.037ms (±0.00%)   | -1.39%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave10000Events ()                | 209.515ms (±0.00%) | 215.137ms (±0.00%) | -2.61%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.873s (±0.00%)    | 7.895s (±0.00%)    | -0.27%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.679s (±0.00%)    | 4.673s (±0.00%)    | +0.14%    | 34.745mb        | 34.745mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 50.483ms (±0.00%)  | 49.260ms (±0.00%)  | +2.48%    | 33.836mb        | 33.836mb   | 0.00%       |
| benchLoad10000Events ()                | 918.600μs (±0.00%) | 917.600μs (±0.00%) | +0.11%    | 33.836mb        | 33.836mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.246ms (±0.00%)   | 4.326ms (±0.00%)   | -1.84%    | 37.072mb        | 37.072mb   | 0.00%       |
| benchSave10000Events () | 334.364ms (±0.00%) | 343.420ms (±0.00%) | -2.64%    | 37.144mb        | 37.144mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 892.400μs (±0.00%) | 882.100μs (±0.00%) | +1.17%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchLoad10000Events ()                | 84.889ms (±0.00%)  | 80.660ms (±0.00%)  | +5.24%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave1Event ()                     | 1.512ms (±0.00%)   | 1.683ms (±0.00%)   | -10.17%   | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000Events ()                | 241.596ms (±0.00%) | 241.017ms (±0.00%) | +0.24%    | 34.897mb        | 34.897mb   | 0.00%       |
| benchSave10000Aggregates ()            | 11.979s (±0.00%)   | 11.872s (±0.00%)   | +0.90%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 8.723s (±0.00%)    | 8.738s (±0.00%)    | -0.16%    | 35.396mb        | 35.396mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 935.100μs (±0.00%) | 992.800μs (±0.00%) | -5.81%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchLoad10000Events ()                | 47.118ms (±0.00%)  | 49.372ms (±0.00%)  | -4.56%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave1Event ()                     | 973.300μs (±0.00%) | 1.034ms (±0.00%)   | -5.91%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Events ()                | 212.836ms (±0.00%) | 212.065ms (±0.00%) | +0.36%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.862s (±0.00%)    | 7.913s (±0.00%)    | -0.64%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.702s (±0.00%)    | 4.681s (±0.00%)    | +0.45%    | 33.765mb        | 33.765mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the deprecate-subscriber-accessor-interface branch from ab6f783 to 3cdc4b4 Compare December 5, 2024 12:18
@DavidBadura DavidBadura merged commit 13b647a into 3.6.x Dec 5, 2024
39 of 40 checks passed
@DavidBadura DavidBadura added this to the 3.6.0 milestone Dec 5, 2024
@DavidBadura DavidBadura deleted the deprecate-subscriber-accessor-interface branch December 5, 2024 12:23
@DanielBadura DanielBadura changed the title deprecate subscriber accessor interface and remove experimantel trace feature Remove trace feature which was experimental, deprecate subscriber accessor interface Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants