Better swift support #128
Merged
Better swift support #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od in a better way
|
@Sega-Zero my apologies at the delay in looking at this. any chance you can address the conflicts here? |
fix conflicts
|
sure, fixed |
|
Thanks for the quick response. Do you think we need any other changes for Swift 2.3? Any thoughts about support for Swift 3? |
|
As long as FastImageCache is used as a framework - nothing more special to be added to support newer swift versions, I think. Nullability and light generics is a must to work comfortable in swift. Haven't looked at 3.0 yet, 2.3 most certainly stay the same. I'll check if there should be more changes for swift 3 and make a new PR if any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied nullabitily macros and light generics as mentioned in #106
Also,
FICImageTableclass has been modernized a little bit:initandnewmethods as unavailable in favor ofinitWithFormat:imageCache:NS_DESIGNATED_INITIALIZERforinitWithFormat:imageCache:It is much better than a crash in runtime.