Change the constant MAX_LABEL_WIDTH_KEY in VerticalAxis to an ins…

…tance-dependent key
patrykandpatrick · Jun 19, 2024 · e97984d · e97984d
1 parent 2321b71
commit e97984d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/vico/core/src/main/java/com/patrykandpatrick/vico/core/axis/vertical/VerticalAxis.kt b/vico/core/src/main/java/com/patrykandpatrick/vico/core/axis/vertical/VerticalAxis.kt
@@ -45,7 +45,6 @@ import com.patrykandpatrick.vico.core.extension.translate
 import com.patrykandpatrick.vico.core.throwable.UnknownAxisPositionException
 
 private const val TITLE_ABS_ROTATION_DEGREES = 90f
-private const val MAX_LABEL_WIDTH_KEY = "maxLabelWidthKey"
 
 /**
  * An implementation of [AxisRenderer] used for vertical axes. This class extends [Axis].
@@ -64,6 +63,8 @@ public class VerticalAxis<Position : AxisPosition.Vertical>(
     private val textHorizontalPosition: HorizontalPosition
         get() = if (areLabelsOutsideAtStartOrInsideAtEnd) HorizontalPosition.Start else HorizontalPosition.End
 
+    private val maxLabelWidthKey = System.identityHashCode(this)
+
     /**
      * The maximum label count.
      */
@@ -221,7 +222,7 @@ public class VerticalAxis<Position : AxisPosition.Vertical>(
                 horizontalPosition = textHorizontalPosition,
                 verticalPosition = verticalLabelPosition.textPosition,
                 rotationDegrees = labelRotationDegrees,
-                maxTextWidth = getExtraOr(MAX_LABEL_WIDTH_KEY) { chartBounds.width().half - tickLength }.toInt(),
+                maxTextWidth = getExtraOr(maxLabelWidthKey) { chartBounds.width().half - tickLength }.toInt(),
             )
         }
     }
@@ -280,7 +281,7 @@ public class VerticalAxis<Position : AxisPosition.Vertical>(
             val labelSpace = when (horizontalLabelPosition) {
                 Outside -> {
                     val maxLabelWidth = getMaxLabelWidth(height).ceil
-                    putExtra(MAX_LABEL_WIDTH_KEY, maxLabelWidth)
+                    putExtra(maxLabelWidthKey, maxLabelWidth)
                     maxLabelWidth + tickLength
                 }