fix issue #1652

paul-buerkner · Sep 12, 2024 · 407cad8 · 407cad8
1 parent 96902a7
commit 407cad8
Show file tree

Hide file tree

Showing 18 changed files with 89 additions and 68 deletions.
diff --git a/R/data-helpers.R b/R/data-helpers.R
@@ -558,6 +558,10 @@ validate_newdata <- function(
     new_levels <- get_levels(bterms, data = newdata)
     for (g in names(old_levels)) {
       unknown_levels <- setdiff(new_levels[[g]], old_levels[[g]])
+      # NA is not found by get_levels but still behaves like a new level (#1652)
+      if (anyNA(newdata[[g]])) {
+        c(unknown_levels) <- NA
+      }
       if (length(unknown_levels)) {
         unknown_levels <- collapse_comma(unknown_levels)
         stop2(

diff --git a/R/prepare_predictions.R b/R/prepare_predictions.R
@@ -1173,10 +1173,11 @@ is.bprepnl <- function(x) {
 #'
 #' @param x An \R object typically of class \code{'brmsfit'}.
 #' @param newdata An optional data.frame for which to evaluate predictions. If
-#'   \code{NULL} (default), the original data of the model is used.
-#'   \code{NA} values within factors are interpreted as if all dummy
-#'   variables of this factor are zero. This allows, for instance, to make
-#'   predictions of the grand mean when using sum coding.
+#'   \code{NULL} (default), the original data of the model is used. \code{NA}
+#'   values within factors (excluding grouping variables) are interpreted as if
+#'   all dummy variables of this factor are zero. This allows, for instance, to
+#'   make predictions of the grand mean when using sum coding. \code{NA} values
+#'   within grouping variables are treated as a new level.
 #' @param re_formula formula containing group-level effects to be considered in
 #'   the prediction. If \code{NULL} (default), include all group-level effects;
 #'   if \code{NA} or \code{~0}, include no group-level effects.

diff --git a/man/fitted.brmsfit.Rd b/man/fitted.brmsfit.Rd
diff --git a/man/get_refmodel.brmsfit.Rd b/man/get_refmodel.brmsfit.Rd
diff --git a/man/log_lik.brmsfit.Rd b/man/log_lik.brmsfit.Rd
diff --git a/man/loo_moment_match.brmsfit.Rd b/man/loo_moment_match.brmsfit.Rd
diff --git a/man/posterior_epred.brmsfit.Rd b/man/posterior_epred.brmsfit.Rd
diff --git a/man/posterior_linpred.brmsfit.Rd b/man/posterior_linpred.brmsfit.Rd
diff --git a/man/posterior_predict.brmsfit.Rd b/man/posterior_predict.brmsfit.Rd
diff --git a/man/pp_check.brmsfit.Rd b/man/pp_check.brmsfit.Rd
diff --git a/man/pp_mixture.brmsfit.Rd b/man/pp_mixture.brmsfit.Rd
diff --git a/man/predict.brmsfit.Rd b/man/predict.brmsfit.Rd
diff --git a/man/predictive_error.brmsfit.Rd b/man/predictive_error.brmsfit.Rd
diff --git a/man/prepare_predictions.Rd b/man/prepare_predictions.Rd
diff --git a/man/psis.brmsfit.Rd b/man/psis.brmsfit.Rd
diff --git a/man/reloo.brmsfit.Rd b/man/reloo.brmsfit.Rd
diff --git a/man/residuals.brmsfit.Rd b/man/residuals.brmsfit.Rd
diff --git a/man/standata.brmsfit.Rd b/man/standata.brmsfit.Rd