Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove importMethodsFrom rstan summary #1661

Merged
merged 1 commit into from
May 24, 2024

Conversation

venpopov
Copy link
Contributor

This PR removes a single @importMethodsFrom rstan summary statement. This import seems to be unused, but it is causing the loading time of brms to be ~ 2.5 seconds (on my machine), because loading rstan is slow. Removing this import speeds up the loading time of brms to ~ 0.6 seconds:

Before:

start <- Sys.time()
library(brms)
Sys.time() - start
#> Time difference of 2.574536 secs

After:

start <- Sys.time()
library(brms)
Sys.time() - start
#> Time difference of 0.616188 secs

All tests and check() pass and I couldn't find any place it's used, so it seems to be leftover code

@paul-buerkner
Copy link
Owner

Thanks! Merging now!

@paul-buerkner paul-buerkner merged commit 7174bea into paul-buerkner:master May 24, 2024
5 checks passed
@venpopov venpopov deleted the improve-load-times branch May 24, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants