remove importMethodsFrom rstan summary #1661
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a single @importMethodsFrom rstan summary statement. This import seems to be unused, but it is causing the loading time of
brms
to be ~ 2.5 seconds (on my machine), because loading rstan is slow. Removing this import speeds up the loading time ofbrms
to ~ 0.6 seconds:Before:
After:
All tests and check() pass and I couldn't find any place it's used, so it seems to be leftover code