Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade AGP to 8.5.2 and Bump Compile Version to API 35 #278

Merged
merged 12 commits into from
Oct 28, 2024

Conversation

sshropshire
Copy link
Collaborator

@sshropshire sshropshire commented Oct 25, 2024

Summary of changes

  • This PR updates compile version across all modules to API 35 (it is currently hardcoded to 31)
  • Upgrade Android Gradle Plugin (AGP) to latest version 8.5.2 to fix a compilation error
    • GitHub Actions: The new version of AGP requires Java 17
  • The Demo application requires the Java 11 JVM toolchain to build because of Hilt
  • This PR also removes jacoco for now. Jacoco was causing build failures after upgrading AGP. We should consider migrating to Jetbrains kotlinx-kover in a future PR

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire requested a review from a team as a code owner October 25, 2024 16:57
@sshropshire sshropshire merged commit a0c65d0 into main Oct 28, 2024
6 checks passed
@sshropshire sshropshire deleted the bump_compile_sdk_version_to_android_15 branch October 28, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants