Fix some issues regarding ANSI CSI handling #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, some attributes set from ECODES will be kept in the dict.
That is a valid way of resetting and must be properly regognized.
Do that so we get the correct order of operations: as the comment says, append_themed_infix(infix) must use the previous (a.k.a. current) attr dict.
guludo
force-pushed
the
nx/fix-ansi
branch
2 times, most recently
from
6efa797
to
2d34256
Compare
|
Force-pushed to fix style. |
Extract existing logic to get ANSI CSIs into a dedicated module. While at it, also implement a function to filter out those escape sequences. That function will be used in a future commit to clean up the message text when generating the quoted text for the a reply.
It is undesirable to have those sequence in the quoted text of a reply message. Remove them.
|
Went through existing issues and realized that this fixes #1531. |
pazz
approved these changes
Apr 12, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replying to an email containing ANSI CSI escapes, those sequences are currently included in the reply's quoted message. This PR makes sure they are removed. While working on it, I realized some other issues in the generation of urwid attributes and added fixes for those as well.