Set the locale to the user’s default setting #1654
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to POSIX, a program which has not called
setlocale(LC_ALL, '')
runs using the portable 'C' locale. Callingsetlocale(LC_ALL, '')
lets it use the default locale as defined by the LANG variable.Source: https://docs.python.org/3/library/locale.html#locale.getdefaultlocale
Applications typically start with a call of
Source: https://docs.python.org/3/library/locale.html#locale.setlocale
Setting the locale fixes the detection of 24h format.
Details
pretty_datetime
function checks iftime.strftime("%p")
is empty for branching between 12h / 24h:alot/alot/helper.py
Lines 216 to 217 in 3a3fc88
According to the documentation above, the locale falls back to C and the format is always 12h. Here is the program to check the behavior:
Before
Output:
After
Output:
Note that the format is blank.