Reacticate CI jobs after switch to pyproject and setuptools #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patches the pyproject.toml file during ci to not install the gpg dependency > 1.10 which does not exist on PyPI. See also https://dev.gnupg.org/T6297
|
@pazz I did not install gpg in ci because it was even more complicated than notmuch. Instead I patch the pyproject dependencies during ci, removing gpg and then add a mock of the package and skip all other tests that depend on the gpg module. This is suboptimal but for me it is still acceptable because we get the python test matrix back and the gpg related tests are still run in the nix ci job. What do you think? |
Sounds like a sensible temporary solution, yes! |
pazz
approved these changes
Aug 12, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to reactivate the unittests on the ubuntu runners and find a replacement for the
petry checkjobs. We can even think about pycodestyle or mypy or the like.@pazz I added this to the 0.11 milestone but I don't know how quickly you want to release that and how quickly I can finish this PR. You can just drop it from 0.11 if you want as we have at least some working CI with the nix flake.