handle JSON exception

avoid “TypeError: Converting circular structure to JSON"
pbakondy · Jun 29, 2015 · 8b1f2ca · 8b1f2ca
1 parent f3c4b13
commit 8b1f2ca
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 7 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "filelogger",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "homepage": "https://github.com/pbakondy/filelogger",
   "authors": [
     "Peter Bakondy <[email protected]>"

diff --git a/dist/filelogger.js b/dist/filelogger.js
@@ -41,13 +41,24 @@ angular.module('fileLogger', ['ngCordova.plugins.file'])
 
       var messages = Array.prototype.slice.call(arguments, 1);
       var message = [ timestamp, level ];
+      var text;
 
       for (var i = 0; i < messages.length; i++ ) {
         if (angular.isArray(messages[i])) {
-          message.push(JSON.stringify(messages[i]));
+          text = '[Array]';
+          try {
+            // avoid "TypeError: Converting circular structure to JSON"
+            text = JSON.stringify(messages[i]);
+          } catch(e) {}
+          message.push(text);
         }
         else if (angular.isObject(messages[i])) {
-          message.push(JSON.stringify(messages[i]));
+          text = '[Object]';
+          try {
+            // avoid "TypeError: Converting circular structure to JSON"
+            text = JSON.stringify(messages[i]);
+          } catch(e) {}
+          message.push(text);
         }
         else {
           message.push(messages[i]);

diff --git a/dist/filelogger.min.js b/dist/filelogger.min.js
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "filelogger",
   "private": false,
   "main": "dist/filelogger",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "repository": {
     "url": "git://github.com/pbakondy/filelogger.git"
   },

diff --git a/src/filelogger.js b/src/filelogger.js
@@ -35,13 +35,24 @@ angular.module('fileLogger', ['ngCordova.plugins.file'])
 
       var messages = Array.prototype.slice.call(arguments, 1);
       var message = [ timestamp, level ];
+      var text;
 
       for (var i = 0; i < messages.length; i++ ) {
         if (angular.isArray(messages[i])) {
-          message.push(JSON.stringify(messages[i]));
+          text = '[Array]';
+          try {
+            // avoid "TypeError: Converting circular structure to JSON"
+            text = JSON.stringify(messages[i]);
+          } catch(e) {}
+          message.push(text);
         }
         else if (angular.isObject(messages[i])) {
-          message.push(JSON.stringify(messages[i]));
+          text = '[Object]';
+          try {
+            // avoid "TypeError: Converting circular structure to JSON"
+            text = JSON.stringify(messages[i]);
+          } catch(e) {}
+          message.push(text);
         }
         else {
           message.push(messages[i]);