Adding new method fillFormWithOptions to avoid modification of fillFo…

…rmWithFlatten
pdffillerjs · Oct 7, 2016 · 7e45c63 · 7e45c63
1 parent 3f0388f
commit 7e45c63
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/index.js b/index.js
@@ -105,7 +105,7 @@
             });
         },
 
-        fillFormWithFlatten: function( sourceFile, destinationFile, fieldValues, shouldFlatten, tempFDFPath, callback ) {
+        fillFormWithOptions: function( sourceFile, destinationFile, fieldValues, shouldFlatten, tempFDFPath, callback ) {
 
             //Generate the data from the field values.
             var tempFDFFile =  "data" + (new Date().getTime()) + ".fdf",
@@ -134,8 +134,12 @@
             } );
         },
 
+        fillFormWithFlatten: function( sourceFile, destinationFile, fieldValues, shouldFlatten, callback ) {
+            this.fillFormWithOptions( sourceFile, destinationFile, fieldValues, shouldFlatten, undefined, callback);
+        },
+
         fillForm: function( sourceFile, destinationFile, fieldValues, callback) {
-            this.fillFormWithFlatten( sourceFile, destinationFile, fieldValues, true, undefined, callback);
+            this.fillFormWithFlatten( sourceFile, destinationFile, fieldValues, true, callback);
         }
 
     };

diff --git a/test/test.js b/test/test.js
@@ -43,7 +43,7 @@ describe('pdfFiller Tests', function(){
 
         it('should create an completely filled PDF that is read-only', function(done) {
             this.timeout(15000);
-            pdfFiller.fillFormWithFlatten( source2PDF, dest2PDF, _data, true, undefined, function(err) {
+            pdfFiller.fillFormWithFlatten( source2PDF, dest2PDF, _data, true, function(err) {
                 pdfFiller.generateFieldJson(dest2PDF, null, function(err, fdfData) {
                     fdfData.length.should.equal(0);
                     done();
@@ -53,7 +53,7 @@ describe('pdfFiller Tests', function(){
 
         it('should create an completely filled PDF that is read-only and with an specific temporary folder for FDF files', function(done) {
             this.timeout(15000);
-            pdfFiller.fillFormWithFlatten( source2PDF, dest2PDF, _data, true, './', function(err) {
+            pdfFiller.fillFormWithOptions( source2PDF, dest2PDF, _data, true, './', function(err) {
                 pdfFiller.generateFieldJson(dest2PDF, null, function(err, fdfData) {
                     fdfData.length.should.equal(0);
                     done();
@@ -68,7 +68,7 @@ describe('pdfFiller Tests', function(){
             var _data2 = {
                 "first_name": "Jerry",
             };
-            pdfFiller.fillFormWithFlatten( source3PDF, dest3PDF, _data2, false, undefined, function(err) {
+            pdfFiller.fillFormWithFlatten( source3PDF, dest3PDF, _data2, false, function(err) {
                 pdfFiller.generateFieldJson(dest3PDF, null, function(err, fdfData) {
                     fdfData.length.should.not.equal(0);
                     done();