Explicitly check that $subject is an instance of HTTP_Request2

No idea why this wasn't done from the very beginning
pear · Oct 31, 2023 · 4d683b1 · 4d683b1
1 parent 09e2232
commit 4d683b1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/HTTP/Request2/Observer/Log.php b/HTTP/Request2/Observer/Log.php
@@ -129,6 +129,9 @@ public function __construct($target = 'php://output', array $events = [])
      */
     public function update(SplSubject $subject)
     {
+        if (!$subject instanceof HTTP_Request2) {
+            return;
+        }
         $event = $subject->getLastEvent();
         if (!in_array($event['name'], $this->events)) {
             return;

diff --git a/HTTP/Request2/Observer/UncompressingDownload.php b/HTTP/Request2/Observer/UncompressingDownload.php
@@ -178,15 +178,17 @@ public function __construct($stream, $maxDownloadSize = null)
     /**
      * Called when the request notifies us of an event.
      *
-     * @param HTTP_Request2 $request The HTTP_Request2 instance
+     * @param HTTP_Request2 $subject The HTTP_Request2 instance
      *
      * @return void
      * @throws HTTP_Request2_MessageException
      */
-    public function update(SplSubject $request)
+    public function update(SplSubject $subject)
     {
-        /* @var $request HTTP_Request2 */
-        $event   = $request->getLastEvent();
+        if (!$subject instanceof HTTP_Request2) {
+            return;
+        }
+        $event   = $subject->getLastEvent();
         $encoded = false;
 
         /* @var $event['data'] HTTP_Request2_Response */