fix(vcard): parse vcard module

[CyrilLacroix]

PR Details

Fix for vCard parsing.

Description

Modules and their function that are responsible for parsing vCards were updated.

Related Issues

closes #1994 closes #2327 closes #2680

Motivation and Context

The vCard was not display, the content of the vCard was sent to Whatsapp chat.

How Has This Been Tested

Tested with a Bot, the vCard is now generated and displayed properly in Whatsapp.

// client initialization...

client.on('ready', async () => {
    const userId = '[email protected]';
    const vCard =
        'BEGIN:VCARD\n' +
        'VERSION:3.0\n' +
        'FN:John Doe\n' +
        'ORG:Microsoft;\n' +
        'TEL;type=CELL;type=VOICE;waid=18006427676:+1 (800) 642 7676\n' +
        'END:VCARD';
    await client.sendMessage(userId, vCard);
});

Types of changes

• Dependency change
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• I have updated the documentation accordingly (index.d.ts).

[tofers]

#1994

[purpshell]

closes #1994

[RC047]

thanks

[nathanfinger]

Should this be working with multiple cards?

[tuyuribr]

Please make ESList god happy

[themazim]

LGTM, works on ios, android and web.

[purpshell]

Remove all formatting changes

[frnndwrms]

@CyrilLacroix

Installing npm install git+https://github.com/CyrilLacroix/whatsapp-web.js.git

get a

TypeError: data.id.id.substring is not a function

When is it going to be merge to master?

[shirser121]

Where we standing with this?

[RC047]

When this pull merge it? It works flawlessly @purpshell @tuyuribr @shirser121

[RC047]

I tested its work

[joweste]

I tested its work

Didn´t work to me

[RemyBoy72]

vcardGetNameFromParsed is no longer usable, I have switched to parsed.N[0].value.join(' ').trim()

Can you share all the code changes need to be placed?

[raisa875647]

how do I solve this, please explain what needs to be replaced.

[poislagarde]

any ETA on this?

[khsoh]

Can this patch be modified to work on v1.25.0 ?

[khsoh]

Hi, I have tested this patch and it works except when the VCARD contains an EMAIL entry. For example, in the example.js file, replace the vCard:

const vCard =
            'BEGIN:VCARD\n' +
            'VERSION:3.0\n' +
            'FN:John Doe\n' +
            'ORG:Microsoft;\n' +
            'EMAIL;type=INTERNET:[email protected]\n' +
            'TEL;type=CELL;type=VOICE;waid=18006427676:+1 (800) 642 7676\n' +
            'END:VCARD';

It will not work. One way to fix this is to replace lines 139-142 of Utils.js with:

        vcardOptions = {
            type: 'vcard',
            subtype: null,
            vcardFormattedName: window.Store.VCardUtils.vcardGetNameFromParsed(parsed)
        };

[alechkos]

@khsoh Thank you!