Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ruff linter #117

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Upgrade Ruff linter #117

merged 2 commits into from
Mar 15, 2024

Conversation

justinmayer
Copy link
Contributor

Some code changes are needed to comply with Ruff 0.3.x, but those changes make the code less readable, so I added NOQA exceptions for those two spots.

In some cases, applying Ruff's UP032 rule makes code less readable.
@justinmayer justinmayer requested a review from phibos March 12, 2024 17:08
Copy link
Collaborator

@phibos phibos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@phibos phibos merged commit ff93111 into main Mar 15, 2024
15 checks passed
@phibos phibos deleted the upgrade-ruff-linter branch March 15, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants