Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add category to protocol config #69

Merged
merged 2 commits into from
Nov 21, 2024
Merged

add category to protocol config #69

merged 2 commits into from
Nov 21, 2024

Conversation

manh-pendle
Copy link
Collaborator

PR Checklist

  • My protocol folder name must be kebab-case.
  • I have set all necessary fields like the example in README file.
  • My protocol's icon is a png image and smaller than 20KB.
  • I have set asset addresses correctly according to their types (PT token address for PT integrations, LP token address for LP integration, etc).
  • I have set the integration URL valid and it points to the appropriate page.
  • I did not change the global config.json file. This file will be automatically generated.

@manh-pendle manh-pendle force-pushed the manh/add-category-to-external-integration branch from d7dbdf7 to e872a8f Compare November 20, 2024 17:47
leduythuccs
leduythuccs approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@leduythuccs leduythuccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leduythuccs leduythuccs merged commit cb0214a into main Nov 21, 2024
1 check passed
@leduythuccs leduythuccs deleted the manh/add-category-to-external-integration branch November 21, 2024 03:44
manh-pendle added a commit that referenced this pull request Nov 25, 2024
@HubertHalim @manh-pendle @github-actions
added categories to existing protocols (#70)
68be2e3 
* add category to protocol config (#69)

* add category to protocol config

* update readme

---------

Co-authored-by: Manh Cao <[email protected]>
Co-authored-by: Manh Cao <[email protected]>

* Merge JSON files

* added categories to existing protocols

* added categories to existing protocols

* case insensitive and force user to enter category

* update config.json main

---------

Co-authored-by: manh-pendle <[email protected]>
Co-authored-by: Manh Cao <[email protected]>
Co-authored-by: Manh Cao <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leduythuccs leduythuccs leduythuccs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manh-pendle @leduythuccs