Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pull_request_template.md #308

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Add pull_request_template.md #308

merged 2 commits into from
Oct 4, 2023

Conversation

ebma
Copy link
Member

@ebma ebma commented Sep 14, 2023

This PR adds a template for pull requests. The template is supposed to remind and help developers to make the product team aware of important changes so that they can prepare the required follow-up tasks.

Closes #307.

@ebma ebma linked an issue Sep 14, 2023 that may be closed by this pull request
Create a template for pull requests #307
Closed
@ebma ebma requested a review from a team September 14, 2023 17:19
gianfra-t
gianfra-t approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@gianfra-t gianfra-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

gianfra-t
gianfra-t approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@gianfra-t gianfra-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the template very good, but also we should also have somewhere in the docs (and perhaps a link to it here in the template) a list of the possible modifications that would indeed require a redeployment. Could be a checklist with the files for example.

@ebma ebma merged commit d9a453a into main Oct 4, 2023
2 checks passed
@ebma ebma deleted the 307-create-a-template-for-pull-requests branch October 4, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianfra-t gianfra-t gianfra-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a template for pull requests
2 participants
@ebma @gianfra-t