-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task 126 add the proxy pallet #325
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebma
reviewed
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the comments. Otherwise, I think it's fine to just use Astar's configuration values. Configuration looks good overall.
b-yap
added a commit
that referenced
this pull request
Nov 6, 2023
b-yap
added a commit
that referenced
this pull request
Nov 8, 2023
b-yap
added a commit
that referenced
this pull request
Nov 10, 2023
ebma
approved these changes
Nov 10, 2023
b-yap
force-pushed
the
126-task-add-the-proxy-pallet-for-all-runtimes
branch
from
November 10, 2023 23:54
2a6c0c1
to
04bca97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/pendulum-chain/tasks/issues/126
The code and the amounts are coming from Astar.
I've expressed the amounts required per chain.