-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New currency type #342
New currency type #342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice description of the PR @gianfra-t.
It seems like we only have a choice between two 'easy' solutions:
- we disallow using
CurrencyId::Token
s in Zenlink pools completely or - we limit it to the
CurrencyId::Token
s that fit into one byte, like you implemented it.
Everything else is probably more complicated because we need to change the ZenlinkLPToken type.
It might be worth discussing these two approaches before we choose one over the other. For now, I would actually vote to go for approach 1) because this way we still have time to think about the 'ideal' approach until we actually need it. If we use approach 2) and a pool is created with this we might limit ourselves in the future if we choose to come up with some fancy custom derivation function of the ID or whatever.
What's your opinion on this @gianfra-t? Maybe also @b-yap, @bogdanS98 and @TorstenStueber
If we are not interested in using Zenlink with these new currency type now, then I also think it is better to just not allow it and in the near future think of another way to derive the IDs not just for this new type but for other types that we could add, according to our future needs. |
True. Alright then let's completely disallow using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
Closes #334.
The new type
CurrencyId::Token(u64)
was added to spacewalk here.The new currency type is disabled to zenlink conversion functions.