Expose parachain-staking methods to RPC in all runtimes #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianfra-t
changed the title
ebma
reviewed
Nov 20, 2023
|
@ebma should we already create ticket for this on the portal? |
|
@prayagd a ticket to employ the exposed functions? Sure, we can create that if it does not yet exist. Note that we need to redeploy the collator nodes on each network for this to take effect though, so merging this PR does not immediately unblock the work on the Portal. |
ebma
approved these changes
Nov 21, 2023
|
CI is failing, let's fix that first |
This reverts commit 0bec85d.
|
Now it should be good! |
gianfra-t
force-pushed
the
add-staking-rpc-calls
branch
from
b6614ae to
548e843
Compare
ebma
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pendulum-chain/product: This PR adds changes to the node client code that require a redeployment of the collator nodes to take effect.
Please ensure that the collator nodes are redeployed after this PR is merged.
This PR adds
get_unclaimed_staking_rewardsandget_staking_ratesmethods fromparachain-stakingto the RPC configuration and allows them to be called.