New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

170 Call Gitlab CI job to Automate Runtime Release #430

Merged

b-yap merged 27 commits into main from task-170-automate-runtime-release-process

Jun 17, 2024

Contributor

b-yap commented Mar 12, 2024 •

edited

Loading

partially closes https://github.com/pendulum-chain/tasks/issues/170.

~~added a script for picking commits related to specific runtime;~~
~~added a github action for srtool (based on bifrost's)~~
~~added a js for authorizing upgrade based on the srtool.~~

~~Full info can be found in the issue.~~

b-yap commented

View reviewed changes

.github/workflows/release.yml Show resolved Hide resolved

b-yap commented

View reviewed changes

.github/workflows/release.yml Show resolved Hide resolved

b-yap commented

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

b-yap commented

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

b-yap commented

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

b-yap commented

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

b-yap commented

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

b-yap changed the title ~~Workflow for Automating Runtime release~~ Workflow for Automating Runtime release (DO NOT MERGE)

b-yap commented

View reviewed changes

.github/workflows/scripts/js/common.js Outdated Show resolved Hide resolved

b-yap marked this pull request as ready for review

March 20, 2024 11:06

b-yap requested a review from a team

March 20, 2024 11:07

gianfra-t reviewed

View reviewed changes

Contributor

gianfra-t left a comment

Looks very good @b-yap !! This will save us a lot of time and potential errors.
I only have one comment but it may not be feasible. Since common.js and the constants are taken from the transaction builder repo, do you think it makes sense to fetch those file as one more step in the last work? So we don't have to keep track of both of them.

I think we could just use run: curl ... but then I don't know because the repo is private.

.github/workflows/scripts/get_commits.sh Outdated Show resolved Hide resolved

ebma reviewed

View reviewed changes

Member

ebma left a comment •

edited

Loading

Wow really cool stuff @b-yap, very impressive! I think for the .js stuff, we should strip this down and reduce the files to maybe just one as there is plenty of code we don't need. Some other changes are required to make this work in CI but it already looks great overall 🙏

Since common.js and the constants are taken from the transaction builder repo, do you think it makes sense to fetch those file as one more step in the last work? So we don't have to keep track of both of them.

Regarding this, I agree and would prefer not to link both of them but keep the code here to a minimum.

.github/workflows/release.yml Outdated Show resolved Hide resolved

.github/workflows/scripts/js/common.js Outdated Show resolved Hide resolved

.github/workflows/scripts/js/parachain_authorize_upgrade.js Outdated Show resolved Hide resolved

TorstenStueber reviewed

View reviewed changes

Member

TorstenStueber left a comment

@b-yap Nice PR, this will really improve our lives.

Some major missing part is of course the creation of a GitHub release but I assume that you will add this to the GitLab CI flow?

.github/workflows/release.yml Outdated Show resolved Hide resolved

.github/workflows/release.yml Outdated Show resolved Hide resolved

.github/workflows/release.yml Outdated Show resolved Hide resolved

.github/workflows/scripts/js/parachain_authorize_upgrade.js Outdated Show resolved Hide resolved

bogdanS98 reviewed

View reviewed changes

Contributor

bogdanS98 left a comment •

edited

Loading

This looks great, good job @b-yap 👍🏼 Can't wait to see it in action! I only left some questions.

.github/workflows/release.yml Outdated Show resolved Hide resolved

.github/workflows/release.yml Outdated Show resolved Hide resolved

.github/workflows/scripts/get_commits.sh Outdated Show resolved Hide resolved

b-yap added 9 commits

May 16, 2024 18:43


          added a script for cleaning up commits

8e1521c

and the srtool


          update the yml to run only on push

e58821c


          rename to srtool-build.yml;

2b57b3b

ONLY performs srtool build.


          remove sub-directories

show only info of compressed-wasm


          add the script for auth upgrade

04ddb0a


          add comments and rename job names

778e2b4


          remove unnecessary loc in the js code

86499dc


          update js code

1a10416


          update js code

4d61a1a

b-yap force-pushed the task-170-automate-runtime-release-process branch from 02e822a to 4d61a1a Compare

May 16, 2024 10:43


          new release yml file

1582ef7

b-yap changed the title ~~Workflow for Automating Runtime release (DO NOT MERGE)~~ Workflow for Automating Runtime release


          remove unused scripts

e00c939

Contributor Author

b-yap commented May 16, 2024

All the scripts have been moved to gitlab.

b-yap changed the title ~~Workflow for Automating Runtime release~~ 170 Call Gitlab CI job to Automate Runtime Release

b-yap commented

View reviewed changes

.github/workflows/release-old.yml Outdated Show resolved Hide resolved


          add the correct gitlab id

a4a5ee0

Contributor Author

b-yap commented May 16, 2024

@TorstenStueber

Some major missing part is of course the creation of a GitHub release but I assume that you will add this to the GitLab CI flow?

Yes, I'll leave that to Zoltan; I've already moved the scripts to gitlab. And the process should be easier over there, than this github CI.

b-yap marked this pull request as draft

May 17, 2024 06:08

b-yap added 14 commits

May 17, 2024 15:01


          test gitlab id

b40dd71


          try to run

ea4a432


          try to run

6df8685


          use another gitlab trigger api

ac72f66


          remove useless lines

85a45a4


          use mb-wali/gitlab-cd-trigger@main github actions

ee97e05


          wrap with double quote

e5e9ad0


          wrap with single quote

48bf536


          wrap with double quote

ecff163


          back with eic but wrap env result with double quote

523ce4c


          use + sign

a372c1c


          Test pendulum

568a01d


          final yaml file

ffbe62e


          remove old release yaml file

76c9387

b-yap marked this pull request as ready for review

May 17, 2024 10:54


          uncomment if statement

7981d43

b-yap requested a review from a team

May 21, 2024 05:47

ebma approved these changes

View reviewed changes

Member

ebma left a comment

Looks good to me, though I did not check the respective commands of the job in Gitlab yet.

Member

ebma commented Jun 13, 2024

I also checked the Gitlab code now and it all looks good to me. Let's merge this now or is there a reason not to do that yet @b-yap?

Contributor Author

b-yap commented Jun 17, 2024

@ebma, I "resolved" the conversations but the Squash and merge button is still disabled. Can you try to "resolve" them and see if it works?

Member

ebma commented Jun 17, 2024

@b-yap should work now, at least it's all green for me.

b-yap merged commit 29e540a into main

3 checks passed

b-yap deleted the task-170-automate-runtime-release-process branch

June 17, 2024 09:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet